From: Juri Linkov <juri@linkov.net>
To: Spyros Roum <spyros.roum@posteo.net>
Cc: philipk@posteo.net, emacs-devel@gnu.org
Subject: Re: Add completion to compilation-read-command
Date: Wed, 25 Dec 2024 19:32:43 +0200 [thread overview]
Message-ID: <87pllf1yrw.fsf@mail.linkov.net> (raw)
In-Reply-To: <962064f8-fab7-4867-af04-135e48a9dd15@posteo.net> (Spyros Roum's message of "Wed, 25 Dec 2024 15:44:42 +0000")
> -(defun compilation-read-command (command)
> +(defun compilation-prompt-read-shell-command (command)
> (read-shell-command "Compile command: " command
> (if (equal (car compile-history) command)
> '(compile-history . 1)
> 'compile-history)))
>
> +(defun compilation-prompt-read-command-with-completion (command)
> + (completing-read "Compile command: " compile-history
> + nil nil command
> + (if (equal (car compile-history) command)
> + '(compile-history . 1)
> + 'compile-history)))
Thanks. The only problem I see is that the function name
doesn't indicate that it's completing on compile-history.
Probably a better name would be:
compilation-read-command-with-history-completion
next prev parent reply other threads:[~2024-12-25 17:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 8:53 Add completion to compilation-read-command Spyros Roum
2024-12-24 11:35 ` Philip Kaludercic
2024-12-24 11:57 ` Spyros Roum
2024-12-24 12:53 ` Philip Kaludercic
2024-12-24 13:43 ` Spyros Roum
2024-12-24 14:53 ` Philip Kaludercic
2024-12-24 17:03 ` Juri Linkov
2024-12-24 18:36 ` Spyros Roum
2024-12-24 18:50 ` Juri Linkov
2024-12-24 18:59 ` Spyros Roum
2024-12-24 22:35 ` Philip Kaludercic
2024-12-25 7:27 ` Juri Linkov
2024-12-24 19:56 ` [External] : " Drew Adams
2024-12-25 7:29 ` Juri Linkov
2024-12-25 19:46 ` Drew Adams
2024-12-24 22:44 ` Philip Kaludercic
2024-12-25 8:26 ` Spyros Roum
2024-12-25 11:33 ` Philip Kaludercic
2024-12-25 15:44 ` Spyros Roum
2024-12-25 16:38 ` Philip Kaludercic
2024-12-25 22:11 ` Spyros Roum
2024-12-25 17:32 ` Juri Linkov [this message]
2024-12-25 18:02 ` Spyros Roum
2024-12-25 19:36 ` [External] : " Drew Adams
2024-12-24 19:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pllf1yrw.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
--cc=spyros.roum@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).