From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: isearch highlighting with zero-length match Date: Sat, 04 Sep 2004 00:53:28 +0300 Organization: JURTA Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <87oekndnon.fsf@mail.jurta.org> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1094248489 14103 80.91.224.253 (3 Sep 2004 21:54:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 3 Sep 2004 21:54:49 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 03 23:54:41 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C3M12-00040K-00 for ; Fri, 03 Sep 2004 23:54:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C3M61-0008MY-If for ged-emacs-devel@m.gmane.org; Fri, 03 Sep 2004 17:59:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C3M5u-0008MS-Pg for emacs-devel@gnu.org; Fri, 03 Sep 2004 17:59:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C3M5t-0008MG-50 for emacs-devel@gnu.org; Fri, 03 Sep 2004 17:59:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C3M5s-0008MC-GD for emacs-devel@gnu.org; Fri, 03 Sep 2004 17:59:41 -0400 Original-Received: from [66.33.205.9] (helo=spatula.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C3M0S-0001cO-4Z for emacs-devel@gnu.org; Fri, 03 Sep 2004 17:54:04 -0400 Original-Received: from mail.jurta.org (80-235-40-34-dsl.mus.estpak.ee [80.235.40.34]) by spatula.dreamhost.com (Postfix) with ESMTP id 7841417D022; Fri, 3 Sep 2004 14:53:59 -0700 (PDT) Original-To: YAMAMOTO Mitsuharu In-Reply-To: (YAMAMOTO Mitsuharu's message of "Thu, 02 Sep 2004 18:00:43 +0900") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26756 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26756 YAMAMOTO Mitsuharu writes: > Could someone please take care of the following issue that I posted to > emacs-pretest-bug in January? Carbon Emacs no longer hangs with this, > but waste of CPU time would occur in any platform. I looked at this patch. It really fixes all mentioned problems and I think it should be installed. I was surprised that `isearch-lazy-highlight-update' is called even for empty search strings. This means that every time users type C-s it iterates over all characters in the window. This may be not noticeable on fast machines, but still is useless. If the search string is "", it is guaranteed that nothing is going to be highlighted. I think `isearch-lazy-highlight-new-loop' should prevent lazy highlighting for empty search strings (I mean if isearch-string is "", not other cases with zero-length matches where there is no such guarantee). -- Juri Linkov http://www.jurta.org/emacs/