From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Brockman Newsgroups: gmane.emacs.devel Subject: Re: `format-spec' fails to pass on text properties Date: Fri, 13 May 2005 18:05:52 +0200 Message-ID: <87oebf5cwv.fsf@wigwam.deepwood.net> References: <877ji36t69.fsf@wigwam.deepwood.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1116001213 24451 80.91.229.2 (13 May 2005 16:20:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 May 2005 16:20:13 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 13 18:20:11 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DWcsX-0007bK-NC for ged-emacs-devel@m.gmane.org; Fri, 13 May 2005 18:19:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DWd1i-0002j4-8S for ged-emacs-devel@m.gmane.org; Fri, 13 May 2005 12:28:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DWcyA-0001Sc-Te for emacs-devel@gnu.org; Fri, 13 May 2005 12:24:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DWcyA-0001SQ-FS for emacs-devel@gnu.org; Fri, 13 May 2005 12:24:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DWcxs-00013q-Qa for emacs-devel@gnu.org; Fri, 13 May 2005 12:24:40 -0400 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1DWco3-0006xg-JZ for emacs-devel@gnu.org; Fri, 13 May 2005 12:14:31 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1DWcYR-0004g0-Sc for emacs-devel@gnu.org; Fri, 13 May 2005 17:58:23 +0200 Original-Received: from c-54b670d5.028-10-67766c2.cust.bredbandsbolaget.se ([213.112.182.84]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 May 2005 17:58:23 +0200 Original-Received: from daniel by c-54b670d5.028-10-67766c2.cust.bredbandsbolaget.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 May 2005 17:58:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 48 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-54b670d5.028-10-67766c2.cust.bredbandsbolaget.se X-Face: :&2UWGm>e24)ip~'K@iOsA&JT3JX*v@1-#L)=dUb825\Fwg#`^N!Y*g-TqdS AevzjFJe96f@V'ya8${57/T'"mTd`1o{TGYhHnVucLq!D$r2O{IN)7>.0op_Y`%r;/Q +(]`3F-t10N7NF\.Mm0q}p1:%iqTi:5]1E]rDF)R$9.!,Eu'9K':y9^U3F8UCS1M+A$ 8[[[WT^`$P[vu>P+8]aQMh9giu&fPCqLW2FSsGs User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:nQ9SdsBYi62J8pqR/ya9cI0iALc= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37085 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37085 --=-=-= Here's a fix that seems to work, but I'm not very experienced in hacking Elisp so I'm probably doing something stupid. --=-=-= Content-Type: text/x-patch Content-Disposition: inline *** emacs/lisp/gnus/format-spec.el~ 2003-09-01 17:45:23.000000000 +0200 --- emacs/lisp/gnus/format-spec.el 2005-05-13 17:48:07.438183352 +0200 *************** *** 45,54 **** (let* ((num (match-string 1)) (spec (string-to-char (match-string 2))) (val (cdr (assq spec specification)))) - (delete-region (1- (match-beginning 0)) (match-end 0)) (unless val (error "Invalid format character: %s" spec)) ! (insert (format (concat "%" num "s") val)))) ;; Signal an error on bogus format strings. (t (error "Invalid format string")))) --- 45,59 ---- (let* ((num (match-string 1)) (spec (string-to-char (match-string 2))) (val (cdr (assq spec specification)))) (unless val (error "Invalid format character: %s" spec)) ! (let ((text (format (concat "%" num "s") val))) ! (insert-and-inherit text) ! ;; Delete the specifier body. ! (delete-region (+ (match-beginning 0) (length text)) ! (+ (match-end 0) (length text))) ! ;; Delete the percent sign. ! (delete-region (1- (match-beginning 0)) (match-beginning 0))))) ;; Signal an error on bogus format strings. (t (error "Invalid format string")))) --=-=-= -- Daniel Brockman --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--