From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: Fx_popup_dialog change breaks Windows build Date: Tue, 24 May 2005 19:17:42 +0200 Message-ID: <87oeb0o85l.fsf@xs4all.nl> References: <87ll65f45m.fsf@xs4all.nl> <17042.60038.573916.269758@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1116955243 6719 80.91.229.2 (24 May 2005 17:20:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 May 2005 17:20:43 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 24 19:20:37 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dad3F-0001Df-Ag for ged-emacs-devel@m.gmane.org; Tue, 24 May 2005 19:18:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dad6w-0002zO-LV for ged-emacs-devel@m.gmane.org; Tue, 24 May 2005 13:22:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dad6S-0002vI-AN for emacs-devel@gnu.org; Tue, 24 May 2005 13:22:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dad6R-0002uj-56 for emacs-devel@gnu.org; Tue, 24 May 2005 13:22:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dad6R-0002u6-1R for emacs-devel@gnu.org; Tue, 24 May 2005 13:22:03 -0400 Original-Received: from [194.109.24.25] (helo=smtp-vbr5.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dad2X-0006O4-V8 for emacs-devel@gnu.org; Tue, 24 May 2005 13:18:02 -0400 Original-Received: from pijl (a80-127-67-124.adsl.xs4all.nl [80.127.67.124]) by smtp-vbr5.xs4all.nl (8.12.11/8.12.11) with ESMTP id j4OHHiwD091949; Tue, 24 May 2005 19:17:44 +0200 (CEST) (envelope-from Lute.Kamstra@xs4all.nl) Original-Received: from lute by pijl with local (Exim 3.36 #1 (Debian)) id 1Dad2E-0003j9-00; Tue, 24 May 2005 19:17:42 +0200 Original-To: Nick Roberts In-Reply-To: <17042.60038.573916.269758@farnswood.snap.net.nz> (Nick Roberts's message of "Tue, 24 May 2005 20:49:10 +1200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 36 X-Virus-Scanned: by XS4ALL Virus Scanner X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37574 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37574 Nick Roberts writes: > Lute Kamstra writes: > > Juanma Barranquero writes: > > > > > This change > > > > > > 2005-05-24 Nick Roberts > > > > > > * xmenu.c (Fx_popup_dialog): Add a third boolean argument to > > > select frame title ("Question"/"Information"). > > > (xdialog_show): Use it. > > > > > > * lisp.h: Fx_popup_dialog can have three arguments. > > > > > > breaks Windows (and, I suppose, Mac) builds. > > > > GNU/Linux too. > > How? Bootstrapping failed during the compilation of fns.c: ... gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. -I/soft/careful/emacs/src -D_BSD_SOURCE -I/usr/X11R6/include -g -O2 fns.c fns.c: In function `Fy_or_n_p': fns.c:3279: error: too few arguments to function `Fx_popup_dialog' fns.c: In function `Fyes_or_no_p': fns.c:3411: error: too few arguments to function `Fx_popup_dialog' make[1]: *** [fns.o] Error 1 make[1]: Leaving directory `/soft/careful/emacs/src' make: *** [bootstrap-build] Error 2 Since your recent change to fns.c, bootstrapping works again. Lute.