From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Yeske Newsgroups: gmane.emacs.devel Subject: Re: rcirc changes Date: Tue, 12 Sep 2006 14:50:26 -0700 Message-ID: <87odtkah5p.fsf@cut.bc.hsia.telus.net> References: <874pvdhvty.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158097877 12533 80.91.229.2 (12 Sep 2006 21:51:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 12 Sep 2006 21:51:17 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 12 23:51:14 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GNG9Y-0007NM-5h for ged-emacs-devel@m.gmane.org; Tue, 12 Sep 2006 23:50:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNG9X-0006Ro-P1 for ged-emacs-devel@m.gmane.org; Tue, 12 Sep 2006 17:50:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GNG9M-0006LE-Fi for emacs-devel@gnu.org; Tue, 12 Sep 2006 17:50:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GNG9K-0006Jw-Go for emacs-devel@gnu.org; Tue, 12 Sep 2006 17:50:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GNG9K-0006Jt-Dy for emacs-devel@gnu.org; Tue, 12 Sep 2006 17:50:34 -0400 Original-Received: from [204.209.205.55] (helo=defout.telus.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GNGAt-00035F-WB for emacs-devel@gnu.org; Tue, 12 Sep 2006 17:52:12 -0400 Original-Received: from priv-edmwaa06.telusplanet.net ([207.6.239.189]) by priv-edmwes24.telusplanet.net (InterMail vM.7.05.01.01 201-2174-106-103-20060222) with ESMTP id <20060912215032.TCVU8231.priv-edmwes24.telusplanet.net@priv-edmwaa06.telusplanet.net>; Tue, 12 Sep 2006 15:50:32 -0600 Original-Received: from cut.bc.hsia.telus.net (d207-6-239-189.bchsia.telus.net [207.6.239.189]) by priv-edmwaa06.telusplanet.net (BorderWare MXtreme Infinity Mail Firewall) with ESMTP id 4320W46TX9; Tue, 12 Sep 2006 15:50:27 -0600 (MDT) Original-To: Chong Yidong In-Reply-To: <874pvdhvty.fsf@stupidchicken.com> (Chong Yidong's message of "Tue\, 12 Sep 2006 12\:51\:37 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (berkeley-unix) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59744 Archived-At: Chong Yidong writes: > Richard Stallman writes: > >> We're waiting for Ryan Yeske's changes about scrolling to >> be installed in rcirc.el. Would someone please install them? > > Done. (I updated FOR-RELEASE too). Thanks for installing this. I since found a problem with how the computation was done, it is not correct when there are continuations of long-lines. Here is a fix. *** rcirc.el 12 Sep 2006 12:04:44 -0700 1.28 --- rcirc.el 12 Sep 2006 14:46:20 -0700 *************** *** 1260,1270 **** (with-current-buffer (window-buffer w) (when (eq major-mode 'rcirc-mode) (with-selected-window w ! (when (<= (- (window-height) ! (- (line-number-at-pos ! (window-point)) ! (line-number-at-pos ! (window-start))) 1) 0) (recenter -1))))))) --- 1260,1269 ---- (with-current-buffer (window-buffer w) (when (eq major-mode 'rcirc-mode) (with-selected-window w ! (when (<= (- (window-height) ! (count-screen-lines ! (window-point) ! (window-start)) 1) 0) (recenter -1)))))))