From: Chong Yidong <cyd@stupidchicken.com>
Cc: keramida@ceid.upatras.gr, emacs-devel@gnu.org
Subject: Re: Minor src/xmenu.c change for older GCC versions
Date: Sun, 05 Nov 2006 12:31:01 -0500 [thread overview]
Message-ID: <87odrlls16.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1Ggc6a-0005qp-RO@fencepost.gnu.org> (Richard Stallman's message of "Sun\, 05 Nov 2006 02\:07\:44 -0500")
Richard Stallman <rms@gnu.org> writes:
> > + FRAME_PTR f;
> > +
> > BLOCK_INPUT;
> > - FRAME_PTR f = check_x_frame (frame);
> > -
> > + f = check_x_frame (frame);
>
> Please add a comment explaining why this is necessary, to make sure
> people don't take this out for elegance's sake.
Done.
prev parent reply other threads:[~2006-11-05 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 21:50 Minor src/xmenu.c change for older GCC versions Giorgos Keramidas
2006-11-04 3:21 ` Chong Yidong
2006-11-05 7:07 ` Richard Stallman
2006-11-05 8:00 ` Giorgos Keramidas
2006-11-05 12:06 ` Eli Zaretskii
2006-11-05 13:18 ` Giorgos Keramidas
2006-11-05 17:31 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87odrlls16.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=keramida@ceid.upatras.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).