[patch] use proper color when drawing border of non-toolkit scroll bars

[patch] use proper color when drawing border of non-toolkit scroll bars

[Andreas Seltenreich]

Hi,

the border of non-toolkit scroll bars seems to ignore attempts to
customize it via the scroll-bar-foreground frame parameter or the
scroll-bar face.  Attached is a trivial patch to fix it, although I'm
not really sure if it qualifies as a bug.

regards,
andreas

Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/src/ChangeLog,v
retrieving revision 1.5527
diff -c -0 -r1.5527 ChangeLog
*** ChangeLog	29 Jan 2007 17:06:15 -0000	1.5527
--- ChangeLog	29 Jan 2007 22:18:56 -0000
***************
*** 0 ****
--- 1,6 ----
+ 2007-01-29  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>
+ 
+ 	* xterm.c [!USE_TOOLKIT_SCROLL_BARS] (x_scroll_bar_expose): Use
+ 	the foreground color of the scroll-bar face when drawing the
+ 	scroll-bar's border.
+ 
Index: xterm.c
===================================================================
RCS file: /sources/emacs/emacs/src/xterm.c,v
retrieving revision 1.938
diff -c -r1.938 xterm.c
*** xterm.c	21 Jan 2007 04:18:14 -0000	1.938
--- xterm.c	29 Jan 2007 22:19:08 -0000
***************
*** 5279,5284 ****
--- 5279,5289 ----
  
    x_scroll_bar_set_handle (bar, XINT (bar->start), XINT (bar->end), 1);
  
+   /* Switch to scroll bar foreground color. */
+   if (f->output_data.x->scroll_bar_foreground_pixel != -1)
+     XSetForeground (FRAME_X_DISPLAY (f), gc,
+ 		    f->output_data.x->scroll_bar_foreground_pixel);
+ 
    /* Draw a one-pixel border just inside the edges of the scroll bar.  */
    XDrawRectangle (FRAME_X_DISPLAY (f), w, gc,
  
***************
*** 5287,5292 ****
--- 5292,5302 ----
  		  XINT (bar->width) - 1 - width_trim - width_trim,
  		  XINT (bar->height) - 1);
  
+   /* Restore the foreground color of the GC if we changed it above.  */
+   if (f->output_data.x->scroll_bar_foreground_pixel != -1)
+     XSetForeground (FRAME_X_DISPLAY (f), gc,
+ 		    f->output_data.x->foreground_pixel);
+ 
    UNBLOCK_INPUT;
  
  }

Re: [patch] use proper color when drawing border of non-toolkit scroll bars

[Leo]

> the border of non-toolkit scroll bars seems to ignore attempts to
> customize it via the scroll-bar-foreground frame parameter or the
> scroll-bar face.  Attached is a trivial patch to fix it, although I'm
> not really sure if it qualifies as a bug.

Can this patch fix this bug:

<http://permalink.gmane.org/gmane.emacs.pretest.bugs/16450>

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: [patch] use proper color when drawing border of non-toolkit scroll bars

[Andreas Seltenreich]

Leo writes:

>> the border of non-toolkit scroll bars seems to ignore attempts to
>> customize it via the scroll-bar-foreground frame parameter or the
>> scroll-bar face.  Attached is a trivial patch to fix it, although I'm
>> not really sure if it qualifies as a bug.
>
> Can this patch fix this bug:
>
> <http://permalink.gmane.org/gmane.emacs.pretest.bugs/16450>

I can't imagine a way how a call to XSetForeground() could affect
those symptoms.

regards,
andreas

Re: [patch] use proper color when drawing border of non-toolkit scroll bars

[David Hansen]

On Mon, 29 Jan 2007 23:37:11 +0100 Andreas Seltenreich wrote:

> the border of non-toolkit scroll bars seems to ignore attempts to
> customize it via the scroll-bar-foreground frame parameter or the
> scroll-bar face.  Attached is a trivial patch to fix it, although I'm
> not really sure if it qualifies as a bug.

Please someone apply it.  It's just a few lines and looks so much
better.

David

Re: [patch] use proper color when drawing border of non-toolkit scroll bars

[Jan Djärv]

Andreas Seltenreich skrev:
> Hi,
> 
> the border of non-toolkit scroll bars seems to ignore attempts to
> customize it via the scroll-bar-foreground frame parameter or the
> scroll-bar face.  Attached is a trivial patch to fix it, although I'm
> not really sure if it qualifies as a bug.

Applied, thanks.  FWIW, I think it is a bug.

	Jan D.

> 
> regards,
> andreas
> 
> Index: ChangeLog
> ===================================================================
> RCS file: /sources/emacs/emacs/src/ChangeLog,v
> retrieving revision 1.5527
> diff -c -0 -r1.5527 ChangeLog
> *** ChangeLog	29 Jan 2007 17:06:15 -0000	1.5527
> --- ChangeLog	29 Jan 2007 22:18:56 -0000
> ***************
> *** 0 ****
> --- 1,6 ----
> + 2007-01-29  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>
> + 
> + 	* xterm.c [!USE_TOOLKIT_SCROLL_BARS] (x_scroll_bar_expose): Use
> + 	the foreground color of the scroll-bar face when drawing the
> + 	scroll-bar's border.
> + 
> Index: xterm.c
> ===================================================================
> RCS file: /sources/emacs/emacs/src/xterm.c,v
> retrieving revision 1.938
> diff -c -r1.938 xterm.c
> *** xterm.c	21 Jan 2007 04:18:14 -0000	1.938
> --- xterm.c	29 Jan 2007 22:19:08 -0000
> ***************
> *** 5279,5284 ****
> --- 5279,5289 ----
>   
>     x_scroll_bar_set_handle (bar, XINT (bar->start), XINT (bar->end), 1);
>   
> +   /* Switch to scroll bar foreground color. */
> +   if (f->output_data.x->scroll_bar_foreground_pixel != -1)
> +     XSetForeground (FRAME_X_DISPLAY (f), gc,
> + 		    f->output_data.x->scroll_bar_foreground_pixel);
> + 
>     /* Draw a one-pixel border just inside the edges of the scroll bar.  */
>     XDrawRectangle (FRAME_X_DISPLAY (f), w, gc,
>   
> ***************
> *** 5287,5292 ****
> --- 5292,5302 ----
>   		  XINT (bar->width) - 1 - width_trim - width_trim,
>   		  XINT (bar->height) - 1);
>   
> +   /* Restore the foreground color of the GC if we changed it above.  */
> +   if (f->output_data.x->scroll_bar_foreground_pixel != -1)
> +     XSetForeground (FRAME_X_DISPLAY (f), gc,
> + 		    f->output_data.x->foreground_pixel);
> + 
>     UNBLOCK_INPUT;
>   
>   }
> 
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel