[ulm@gentoo.org: Emacs 22.1 compiler warnings if configured --with-x-toolkit=no]

[ulm@gentoo.org: Emacs 22.1 compiler warnings if configured --with-x-toolkit=no]

[Richard Stallman]

Would someone please install this in the Emacs 22 branch, and in the trunk,
and then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 4 Jun 2007 01:02:29 +0200
From: Ulrich Mueller <ulm@gentoo.org>
To: bug-gnu-emacs@gnu.org
Cc: emacs@gentoo.org
Subject: Emacs 22.1 compiler warnings if configured --with-x-toolkit=no

During compilation of Emacs 22.1 (and 21.4, too) the following
warnings appear:

   i686-pc-linux-gnu-gcc -c  -D_BSD_SOURCE     -D_BSD_SOURCE
   -march=pentium-m -O2 -pipe -DEMACS_BITMAP_FILES -I../src
   -I/var/tmp/portage/app-editors/emacs-22.1/work/emacs-22.1/oldXMenu
   -I/var/tmp/portage/app-editors/emacs-22.1/work/emacs-22.1/oldXMenu/../src
   ChgPane.c
   ChgPane.c: In function 'XMenuChangePane':
   ChgPane.c:46: warning: incompatible implicit declaration of built-in
   function 'strlen'

   i686-pc-linux-gnu-gcc -c  -D_BSD_SOURCE     -D_BSD_SOURCE
   -march=pentium-m -O2 -pipe -DEMACS_BITMAP_FILES -I../src
   -I/var/tmp/portage/app-editors/emacs-22.1/work/emacs-22.1/oldXMenu
   -I/var/tmp/portage/app-editors/emacs-22.1/work/emacs-22.1/oldXMenu/../src
   ChgSel.c
   ChgSel.c: In function 'XMenuChangeSelection':
   ChgSel.c:62: warning: incompatible implicit declaration of built-in
   function 'strlen'

Emacs was configured as follows:

   configure  '--prefix=/usr' '--host=i686-pc-linux-gnu'
   '--mandir=/usr/share/man' '--infodir=/usr/share/info'
   '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib'
   '--program-suffix=-emacs-22' '--infodir=/usr/share/info/emacs-22'
   '--without-carbon' '--with-sound' '--with-x' '--with-xpm'
   '--without-toolkit-scroll-bars' '--with-jpeg' '--with-tiff'
   '--with-gif' '--with-png' '--with-x-toolkit=no' '--without-gtk'
   '--build=i686-pc-linux-gnu' 'build_alias=i686-pc-linux-gnu'
   'host_alias=i686-pc-linux-gnu' 'CFLAGS=-march=pentium-m -O2 -pipe'

This patch should fix the problem:

- --- emacs-22.1-orig/oldXMenu/ChgPane.c	2007-02-27 04:04:22.000000000 +0100
+++ emacs-22.1/oldXMenu/ChgPane.c	2007-06-04 00:47:56.000000000 +0200
@@ -13,6 +13,7 @@
  *
  */
 
+#include <config.h>
 #include "XMenuInt.h"
 
 int
- --- emacs-22.1-orig/oldXMenu/ChgSel.c	2007-02-27 04:04:22.000000000 +0100
+++ emacs-22.1/oldXMenu/ChgSel.c	2007-06-04 00:47:42.000000000 +0200
@@ -13,6 +13,7 @@
  *
  */
 
+#include <config.h>
 #include "XMenuInt.h"
 
 int


Ulrich


_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------

Re: [ulm@gentoo.org: Emacs 22.1 compiler warnings if configured --with-x-toolkit=no]

[Thien-Thi Nguyen]

() Richard Stallman <rms@gnu.org>
() Mon, 04 Jun 2007 01:01:09 -0400

   Would someone please install this in the Emacs 22 branch,
   and in the trunk, and then ack?

done.

for "Emacs 22 branch", i used "cvs checkout -r EMACS_22_BASE".
since this is the first time i have done maintenance on that branch,
please let me know if i overlooked anything.

thi