From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Thu, 06 Mar 2008 15:29:04 -0500 Message-ID: <87od9rzje7.fsf@red-bean.com> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204835478 14856 80.91.229.12 (6 Mar 2008 20:31:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Mar 2008 20:31:18 +0000 (UTC) Cc: Tassilo Horn , Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 06 21:31:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXMkI-0004hh-GN for ged-emacs-devel@m.gmane.org; Thu, 06 Mar 2008 21:31:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXMjk-0004up-V6 for ged-emacs-devel@m.gmane.org; Thu, 06 Mar 2008 15:30:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXMiH-00030M-Tp for emacs-devel@gnu.org; Thu, 06 Mar 2008 15:29:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXMiH-0002yT-5h for emacs-devel@gnu.org; Thu, 06 Mar 2008 15:29:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXMiG-0002yI-WF for emacs-devel@gnu.org; Thu, 06 Mar 2008 15:29:13 -0500 Original-Received: from sanpietro.red-bean.com ([66.146.193.61]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JXMiG-0006Vi-LA for emacs-devel@gnu.org; Thu, 06 Mar 2008 15:29:12 -0500 Original-Received: from localhost ([127.0.0.1]:43252 ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.68) (envelope-from ) id 1JXMi9-0004rL-2H; Thu, 06 Mar 2008 14:29:06 -0600 In-Reply-To: <87zltbhbq8.fsf@bzg.ath.cx> (Bastien's message of "Thu\, 06 Mar 2008 19\:51\:59 +0000") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91546 Archived-At: Bastien writes: > Two answers: yes gnus-bookmarks.el should stored Gnus bookmarks in > ~/.emacs.bmk (as every mode should do), but no we can't get rid of > gnus-bookmarks.el because it adds some keybindings to Gnus. Sure -- the existence of the file isn't a problem. Whatever method we have of establishing those keybindings in Gnus is fine. I just meant that the Gnus keybindings should bind to standard bookmark functions, and those functions should DTRT for Gnus. (As you seem to be proposing below, too.) > I think we should continue and generalize the work done by Tassilo. > > He added the buffer-local variable `bookmark-make-cell-function', which > lets you define a handler for a mode: when setting a bookmark, a handler > is added to the record and jumping to the bookmark will use this handler > instead of `bookmark-jump' (see `bookmark-jump-internal'.) > > This is all good, but it only works for buffer visiting files and > Info-mode. Yup. The idea (as I understand it) was precisely that we could extend it to handle other things, like Gnus. > What would be great would be to change `bookmark-set' like this: > > - run every function in `bookmark-set-functions' until one returns > something useful (those functions returning something similar to > ` bookmark-buffer-file-name'); > > - if nil, then fall back on `bookmark-buffer-file-name' and return > an error if this is nil. > > > If we go for this, then gnus-bookmarks.el would do this: > > - add a function to `bookmark-set-functions', so that it return a > sensible value (instead of the buffer-file-name) > > - locally set `bookmark-make-cell-function' to define the right handler > (which should select a group/article in Gnus) > > I think this way let's people easily define man-bmk.el, or mew-bmk.el or > whatever. > > What you think? It sounds like a good plan to me. Er, do you have time to do it? I can add it to my queue, but I'm behind as it is, and I think it would be some weeks at a minimum before I could look at it, unfortunately. -Karl