From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: vc-toggle-read-only mishandles CVS ro file in presence of CVSREAD=1 Date: Wed, 25 Jun 2008 07:04:33 +0200 Message-ID: <87od5q9kbi.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214370462 26029 80.91.229.12 (25 Jun 2008 05:07:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Jun 2008 05:07:42 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 25 07:08:27 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KBNF3-0000BD-D1 for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2008 07:08:25 +0200 Original-Received: from localhost ([127.0.0.1]:34569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBNED-00061f-VX for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2008 01:07:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KBNE6-0005zz-KY for emacs-devel@gnu.org; Wed, 25 Jun 2008 01:07:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KBNE4-0005xw-3g for emacs-devel@gnu.org; Wed, 25 Jun 2008 01:07:25 -0400 Original-Received: from [199.232.76.173] (port=52215 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBNE4-0005xm-07 for emacs-devel@gnu.org; Wed, 25 Jun 2008 01:07:24 -0400 Original-Received: from [151.61.142.243] (port=40523 helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KBNE3-000487-BO for emacs-devel@gnu.org; Wed, 25 Jun 2008 01:07:23 -0400 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1KBNBJ-0003ht-VH for emacs-devel@gnu.org; Wed, 25 Jun 2008 07:04:33 +0200 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99890 Archived-At: While investigating the pgg-gpg.el bug report (another thread), i did a cvs update and now `C-x C-q' bleats on a CVS-controlled read-only file (w/ env var `CVSREAD' set to "1"). This used to work before, so i consider the current situation a regression. I see vc-toggle-read-only now reads: | (defun vc-toggle-read-only (&optional verbose) | "Change read-only status of current buffer, perhaps via version control. | | If the buffer is visiting a file registered with version control, | throw an error, because this is not a safe or really meaningful operation | on any version-control system newer than RCS. | | Otherwise, just change the read-only flag of the buffer. | | If you bind this function to \\[toggle-read-only], then Emacs | will properly intercept all attempts to toggle the read-only flag | on version-controlled buffer." | (interactive "P") | (if (vc-backend buffer-file-name) | (error "Toggling the readability of a version controlled file is likely to wreak havoc.") | (toggle-read-only))) The "not a safe ... newer than RCS" blurb is (gratuitously) wrong, but at least we know the authors' bias up front. I suggest we remove that blurb and use checkout-model info to make this command DTRT again. thi