unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: emacs-devel@gnu.org
Subject: vc-toggle-read-only mishandles CVS ro file in presence of CVSREAD=1
Date: Wed, 25 Jun 2008 07:04:33 +0200	[thread overview]
Message-ID: <87od5q9kbi.fsf@ambire.localdomain> (raw)

While investigating the pgg-gpg.el bug report (another thread), i
did a cvs update and now `C-x C-q' bleats on a CVS-controlled
read-only file (w/ env var `CVSREAD' set to "1").  This used to
work before, so i consider the current situation a regression.

I see vc-toggle-read-only now reads:

| (defun vc-toggle-read-only (&optional verbose)
|   "Change read-only status of current buffer, perhaps via version control.
| 
| If the buffer is visiting a file registered with version control,
| throw an error, because this is not a safe or really meaningful operation
| on any version-control system newer than RCS.
| 
| Otherwise, just change the read-only flag of the buffer.
| 
| If you bind this function to \\[toggle-read-only], then Emacs
| will properly intercept all attempts to toggle the read-only flag
| on version-controlled buffer."
|   (interactive "P")
|   (if (vc-backend buffer-file-name)
|       (error "Toggling the readability of a version controlled file is likely to wreak havoc.")
|     (toggle-read-only)))

The "not a safe ... newer than RCS" blurb is (gratuitously) wrong,
but at least we know the authors' bias up front.  I suggest we
remove that blurb and use checkout-model info to make this command
DTRT again.

thi




             reply	other threads:[~2008-06-25  5:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25  5:04 Thien-Thi Nguyen [this message]
2008-06-25  5:36 ` vc-toggle-read-only mishandles CVS ro file in presence of CVSREAD=1 Miles Bader
2008-06-25  9:35   ` Thien-Thi Nguyen
2008-06-25 14:10     ` Miles Bader
2008-06-25 14:40       ` Thien-Thi Nguyen
2008-07-23 10:02         ` Thien-Thi Nguyen
2008-06-25 15:48       ` Stefan Monnier
2008-06-25 16:27         ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87od5q9kbi.fsf@ambire.localdomain \
    --to=ttn@gnuvola.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).