From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Emacs 22.2.90 pretest Date: Sat, 16 Aug 2008 09:43:19 -0400 Message-ID: <87od3tkrd4.fsf@stupidchicken.com> References: <87y72ymcig.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218894219 18199 80.91.229.12 (16 Aug 2008 13:43:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Aug 2008 13:43:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 16 15:44:31 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KUM4y-0004Q0-VI for ged-emacs-devel@m.gmane.org; Sat, 16 Aug 2008 15:44:29 +0200 Original-Received: from localhost ([127.0.0.1]:39371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUM42-00050d-4R for ged-emacs-devel@m.gmane.org; Sat, 16 Aug 2008 09:43:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KUM3x-0004zx-0T for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:43:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KUM3w-0004zf-4w for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:43:24 -0400 Original-Received: from [199.232.76.173] (port=51481 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUM3v-0004zY-QJ for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:43:23 -0400 Original-Received: from c-24-63-201-57.hsd1.ma.comcast.net ([24.63.201.57]:24898 helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KUM3r-0001ZD-Uy; Sat, 16 Aug 2008 09:43:20 -0400 Original-Received: by furry (Postfix, from userid 1000) id 3BA35C058; Sat, 16 Aug 2008 09:43:19 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Sat, 16 Aug 2008 11:41:51 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102530 Archived-At: Eli Zaretskii writes: > I notice that in this pretest, moving point with C-f and C-b or > inserting a single character is very sluggish: e.g., if I continuously > press C-f, Emacs cannot keep up(!), although this is a 3.2 GHz > machine. It almost feels like working on a remote machine. > > This recent change seems to be a likely suspect: > > 2008-07-28 Chong Yidong > > * textmodes/flyspell.el (flyspell-word, flyspell-large-region) > (flyspell-region): Call ispell-maybe-find-aspell-dictionaries. > > It seems that its effect is to call ispell-maybe-find-aspell-dictionaries > on every editing command, which is silly, IMO. Even if we do need to do > that on every command (and I'd like to hear a reason why), the call > should only be made if Ispell is actually Aspell, which in my case it > isn't. On top of that, ispell-maybe-find-aspell-dictionaries > obviously was not designed to be called frequently: it calls > ispell-check-version, which is expensive and is supposed to be run > once in an Ispell session (it makes unnecessary destructive changes to > the Ispell buffer, invokes another Ispell process, etc.). > > Why was this change made? This was bug#232: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=232 Does undoing this change make the problem go away? If so, it's probably better to revert it. (I attempted to backport a change from the trunk to the branch, but there were other changes to the trunk that apparently makes the dictionary initialization less expensive.)