unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs 22.2.90 pretest
Date: Sat, 16 Aug 2008 09:43:19 -0400	[thread overview]
Message-ID: <87od3tkrd4.fsf@stupidchicken.com> (raw)
In-Reply-To: <ud4k95p2o.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Aug 2008 11:41:51 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> I notice that in this pretest, moving point with C-f and C-b or
> inserting a single character is very sluggish: e.g., if I continuously
> press C-f, Emacs cannot keep up(!), although this is a 3.2 GHz
> machine.  It almost feels like working on a remote machine.
>
> This recent change seems to be a likely suspect:
>
>    2008-07-28  Chong Yidong  <cyd@stupidchicken.com>
>
> 	   * textmodes/flyspell.el (flyspell-word, flyspell-large-region)
> 	   (flyspell-region): Call ispell-maybe-find-aspell-dictionaries.
>
> It seems that its effect is to call ispell-maybe-find-aspell-dictionaries
> on every editing command, which is silly, IMO.  Even if we do need to do
> that on every command (and I'd like to hear a reason why), the call
> should only be made if Ispell is actually Aspell, which in my case it
> isn't.  On top of that, ispell-maybe-find-aspell-dictionaries
> obviously was not designed to be called frequently: it calls
> ispell-check-version, which is expensive and is supposed to be run
> once in an Ispell session (it makes unnecessary destructive changes to
> the Ispell buffer, invokes another Ispell process, etc.).
>
> Why was this change made?

This was bug#232:

http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=232

Does undoing this change make the problem go away?  If so, it's probably
better to revert it.  (I attempted to backport a change from the trunk
to the branch, but there were other changes to the trunk that apparently
makes the dictionary initialization less expensive.)




  reply	other threads:[~2008-08-16 13:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 17:08 Emacs 22.2.90 pretest Chong Yidong
2008-08-16  7:57 ` Eli Zaretskii
2008-08-16  8:20   ` Eli Zaretskii
2008-08-16  8:41   ` Eli Zaretskii
2008-08-16 13:43     ` Chong Yidong [this message]
2008-08-16 15:23       ` Agustin Martin
2008-08-16 16:53         ` Chong Yidong
2008-08-16 16:20       ` Eli Zaretskii
2008-08-16 13:47   ` Chong Yidong
2008-08-17  5:09   ` Jason Rumney
2008-08-17 18:44     ` Eli Zaretskii
2008-08-17 17:54 ` Lennart Borgman (gmail)
2008-08-20  8:10 ` YAMAMOTO Mitsuharu
2008-08-20 14:44   ` Chong Yidong
2008-08-25 18:54     ` Eli Zaretskii
2008-08-20 16:07   ` Eli Zaretskii
2008-08-21  0:51     ` YAMAMOTO Mitsuharu
2008-08-21  5:35       ` Eli Zaretskii
2008-08-21  6:16         ` YAMAMOTO Mitsuharu
2008-08-21 11:25           ` Kenichi Handa
2008-08-20  8:21 ` YAMAMOTO Mitsuharu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87od3tkrd4.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).