From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Hanchrow Newsgroups: gmane.emacs.devel Subject: Re: vc-git-show-log-entry Date: Mon, 20 Oct 2008 08:01:29 -0700 Message-ID: <87od1fl392.fsf@offby1.atm01.sea.blarg.net> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224530150 17823 80.91.229.12 (20 Oct 2008 19:15:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Oct 2008 19:15:50 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 20 21:16:10 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KrwO3-0007Qt-IW for ged-emacs-devel@m.gmane.org; Mon, 20 Oct 2008 17:09:40 +0200 Original-Received: from localhost ([127.0.0.1]:46590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KrwMw-0002o7-U3 for ged-emacs-devel@m.gmane.org; Mon, 20 Oct 2008 11:08:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KrwMs-0002nI-Lm for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:08:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KrwMq-0002mN-Lj for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:08:25 -0400 Original-Received: from [199.232.76.173] (port=56427 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KrwMq-0002mK-Fw for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:08:24 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:60186 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KrwMq-0001Wm-72 for emacs-devel@gnu.org; Mon, 20 Oct 2008 11:08:24 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KrwMc-0004Jq-P6 for emacs-devel@gnu.org; Mon, 20 Oct 2008 15:08:10 +0000 Original-Received: from q-static-138-125.avvanta.com ([206.124.138.125]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Oct 2008 15:08:10 +0000 Original-Received: from offby1 by q-static-138-125.avvanta.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Oct 2008 15:08:10 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: q-static-138-125.avvanta.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:ZKAnsfZzTI3Lm+Rxt58mX8msCg8= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104683 Archived-At: >>>>> "Karl" == Karl Chen writes: Karl> I looked at CVS HEAD and noticed a new vc-git-show-log-entry Karl> and some recent modifications. I believe the vc-git.el:1.72 Karl> version would do the right thing for my use case, but I Karl> suspect the r1.73 change: * vc-git.el (vc-git-show-log-entry): Karl> Include the revision in the search string. breaks it. I'm pretty sure that change was mine << glances around nervously >>. I didn't really understand what I was doing with that change; I just stuck something in there that seemed to work for me. It sounds like you understand vc-git better than I did. I'll see if yours works for me; if so, let's get your change in instead. Karl> Personally, I like the vc-git-rev-parse solution better. It Karl> handles every method of specifying commits, the "git way". Sounds good to me! -- As economics is known as "The Miserable Science", software engineering should be known as "The Doomed Discipline" -- Edsger Dijkstra