unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Hanchrow <offby1@blarg.net>
To: emacs-devel@gnu.org
Subject: Re: vc-git-show-log-entry
Date: Mon, 20 Oct 2008 08:01:29 -0700	[thread overview]
Message-ID: <87od1fl392.fsf@offby1.atm01.sea.blarg.net> (raw)
In-Reply-To: quack.20081020T0236.lthtzb7ip51@roar.cs.berkeley.edu

>>>>> "Karl" == Karl Chen <quarl@cs.berkeley.edu> writes:

    Karl> I looked at CVS HEAD and noticed a new vc-git-show-log-entry
    Karl> and some recent modifications.  I believe the vc-git.el:1.72
    Karl> version would do the right thing for my use case, but I
    Karl> suspect the r1.73 change: * vc-git.el (vc-git-show-log-entry):
    Karl> Include the revision in the search string.  breaks it.  

I'm pretty sure that change was mine << glances around nervously >>.  I
didn't really understand what I was doing with that change; I just stuck
something in there that seemed to work for me.  It sounds like you
understand vc-git better than I did.  I'll see if yours works for me; if
so, let's get your change in instead.

    Karl> Personally, I like the vc-git-rev-parse solution better.  It
    Karl> handles every method of specifying commits, the "git way".

Sounds good to me!

-- 
As economics is known as "The Miserable Science", software
engineering should be known as "The Doomed Discipline"
        -- Edsger Dijkstra





  reply	other threads:[~2008-10-20 15:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20  9:36 vc-git-show-log-entry Karl Chen
2008-10-20 15:01 ` Eric Hanchrow [this message]
2008-10-20 15:09 ` vc-git-show-log-entry Eric Hanchrow
2008-10-20 18:19 ` vc-git-show-log-entry Dan Nicolaescu
2008-10-20 20:20   ` vc-git-show-log-entry Karl Chen
2008-10-20 22:10     ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21  7:23       ` vc-git-show-log-entry Karl Chen
2008-10-21  8:49         ` vc-git-show-log-entry Dan Nicolaescu
2008-10-21 17:52       ` vc-git-show-log-entry Alexandre Julliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87od1fl392.fsf@offby1.atm01.sea.blarg.net \
    --to=offby1@blarg.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).