From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: VC Development Date: Sun, 01 Feb 2009 09:25:55 -0500 Message-ID: <87ocxmnsi4.fsf@cyd.mit.edu> References: <18820.57748.262639.494922@kahikatea.snap.net.nz> <8763ju6gh9.fsf@cyd.mit.edu> <200902010602.n11620Ek019863@rodan.ics.uci.edu> <18821.23162.152202.54979@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233498338 12724 80.91.229.12 (1 Feb 2009 14:25:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Feb 2009 14:25:38 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 01 15:26:50 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LTdHc-0007V4-Rc for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2009 15:26:49 +0100 Original-Received: from localhost ([127.0.0.1]:46447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTdGH-0005ew-SM for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2009 09:25:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LTdGD-0005eh-JC for emacs-devel@gnu.org; Sun, 01 Feb 2009 09:25:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LTdGB-0005eV-US for emacs-devel@gnu.org; Sun, 01 Feb 2009 09:25:20 -0500 Original-Received: from [199.232.76.173] (port=48705 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTdGB-0005eS-Ln for emacs-devel@gnu.org; Sun, 01 Feb 2009 09:25:19 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:33629) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LTdGB-0007v0-Df for emacs-devel@gnu.org; Sun, 01 Feb 2009 09:25:19 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 59AE057E196; Sun, 1 Feb 2009 09:25:55 -0500 (EST) In-Reply-To: <18821.23162.152202.54979@kahikatea.snap.net.nz> (Nick Roberts's message of "Sun, 1 Feb 2009 21:16:58 +1300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108518 Archived-At: Nick Roberts writes: > OK. I see now that I should have used copy-keymap: > > (defvar vc-dir-mouse-map > (let ((map (copy-keymap vc-dir-mode-map))) > ... > > I would like to see this change go in before the pretest. Since I'm > evidently in Dan's killfile this must be a request to the maintainers. > In case there is any confusion, with my proposed change, mouse-2 still > toggles the mark when clicked over the status (first mouse highlight > region) but over the filename (second mouse highlight region) now > visits that file in another buffer. Unfortunately, I am not familiar enough with the VC code to make a good technical judgement call in this case. IMO, your change is not an obvious improvement---the check-box interface I mentioned seems to be a more intuitive way to toggle the mark with the mouse. So, I prefer to stick with the current state of affairs (i.e., how vc-dir has been behaving since it was written), until that interface can be implemented. > I would also like to see stay-local behaviour working. I can look at > making vc-svn-registered not use "svn status -v DIR", so that > vc-stay-local-p is not so slow, but clearly it is not worthwhile if > Dan is going to revert all my changes and refuse to discuss the > reasons why. I think using the local directory tree is the correct thing to do. It is clearly not feasible to implement and test it before the pretest, but please try working on it. (Stefan, any thoughts?)