From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). Date: Wed, 14 Jul 2010 11:06:13 +0200 Organization: ThierryVolpiatto Message-ID: <87oceabfga.fsf@tux.homenetwork> References: <87y6dydn6q.fsf@tux.homenetwork> <201006292126.15409.tassilo@member.fsf.org> <87iq51ehnv.fsf@tux.homenetwork> <201006292210.43121.tassilo@member.fsf.org> <87eifpegqx.fsf@tux.homenetwork> <87k4ozdq6b.fsf_-_@red-bean.com> <87d3urdppj.fsf@red-bean.com> <87sk3mbh60.fsf@tux.homenetwork> <83oceaqx0z.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279098555 10092 80.91.229.12 (14 Jul 2010 09:09:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 09:09:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 14 11:09:13 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYxxo-000061-PK for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 11:09:13 +0200 Original-Received: from localhost ([127.0.0.1]:36802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYxxn-0004nC-R2 for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 05:09:11 -0400 Original-Received: from [140.186.70.92] (port=39144 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYxxd-0004hf-1f for emacs-devel@gnu.org; Wed, 14 Jul 2010 05:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYxxb-0004vr-O0 for emacs-devel@gnu.org; Wed, 14 Jul 2010 05:09:00 -0400 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:54211) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYxxb-0004vF-Iy; Wed, 14 Jul 2010 05:08:59 -0400 Original-Received: by wwb34 with SMTP id 34so264860wwb.0 for ; Wed, 14 Jul 2010 02:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=FsWDH4BO+zJxfttAcgLtkncswUjIFB+CjSwq1dI24xs=; b=klgwKIDClNX++LonP6vBoDRy0C9YTdyk9Kq610//8lSGwj+edbZbiWu7P8dIMNvqTM miAt/+pWVCUPaczz2/8gglNUZ7T3crewX0YRS25MN8APZ84+DebyCuTQIMbbLKRq9F9U ocSjKZFzPg8PWQYW9HrQkmXg1T6TYFVaNZm80= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=QuHucDGvTFc5ohkymvPa8VjGVQXJmVYnSpZjRtHn/yfCHW5tmsLKQ1Txt6fqCAipnv PIlk2oXSp8MmxxIukE4iMwhrFKKArskLAX6vc0VNXqbHBgxHPsT4L1kOAGFq7J4jt8sa tAW1qol9J/xpsNMtv+MALyVu4eW2Outoh0/VY= Original-Received: by 10.216.81.195 with SMTP id m45mr11530382wee.23.1279098537474; Wed, 14 Jul 2010 02:08:57 -0700 (PDT) Original-Received: from tux.homenetwork ([77.197.77.27]) by mx.google.com with ESMTPS id m38sm2972232wej.19.2010.07.14.02.08.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 14 Jul 2010 02:08:56 -0700 (PDT) In-Reply-To: <83oceaqx0z.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Jul 2010 11:37:32 +0300") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127266 Archived-At: Eli Zaretskii writes: >> From: Thierry Volpiatto >> Date: Wed, 14 Jul 2010 10:29:11 +0200 >> >> if patch WORK and is basically correct and is accepted of course, why >> not applying patch as it is and modifying as Emacs developpers like in >> one or more little other commits. > > Because there's a pedagogical value for the contributors in having > them fix their code according to review comments. That's the case where contributor modify himself the code according to diverse comments. I agree. But i am speaking of the case where contributor's code is modified by Emacs developers, in this case it is better (IMHO) to commit over the initial patch, specially if Emacs developer misunderstand some part of code and make wrong changes (That's not the case here Karl ;-)) it is easier to find whats wrong instead of long discussion. Generally contributor need to all rewrite, sometime long time further. That is extra work for contributor and also Emacs developer. > In general, you learn better what you do yourself, rather than > watching others do it for you. Yes i agree completely. -- Thierry Volpiatto Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997