From: Juri Linkov <juri@jurta.org>
To: "Aurélien Aptel" <aurelien.aptel+emacs@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Drew Adams <drew.adams@oracle.com>,
emacs-devel@gnu.org
Subject: Re: [patch] add "underwave" face attribute
Date: Thu, 02 Feb 2012 01:11:31 +0200 [thread overview]
Message-ID: <87obtii1y4.fsf@mail.jurta.org> (raw)
In-Reply-To: <CA+5B0FPtVVK=BtPqCwE-0yeQR3Rx65evAF-vee3ZmvE6dzO-dg@mail.gmail.com> ("Aurélien Aptel"'s message of "Wed, 1 Feb 2012 00:38:40 +0100")
> (:underline
> (choice :tag "Underline"
> :help-echo "Control text underlining."
> (const :tag "Off" nil)
> (list :tag "On"
> (const :format "" :value :color)
> (choice :tag "Color" (const :tag "Foreground Color" foreground-color) color)
> (const :format "" :value :style)
> (choice :tag "Style"
> (const :tag "Line" line)
> (const :tag "Wave" wave)))))
Very nice, we could use it for `flyspell', `flymake', `next-error'
to highlight errors, etc.
But what to do with platforms where it's not yet supported?
There should be a way to detect its availability
and to fall back to other face attributes.
Currently `:underline' can test its support with `(supports :underline t)'.
Maybe `underwave' should do this with something like:
(defface underwave
'((((supports :underline wave))
:underline (:style wave :color "red"))
(t
:underline (:style line :color "red")))
"Basic underwave face."
:group 'basic-faces)
next prev parent reply other threads:[~2012-02-01 23:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 20:16 [patch] add "underwave" face attribute Aurélien Aptel
2012-01-27 15:50 ` Stefan Monnier
2012-01-27 17:08 ` Drew Adams
2012-01-31 23:38 ` Aurélien Aptel
2012-02-01 16:21 ` Leo
2012-02-01 23:11 ` Juri Linkov [this message]
2012-02-02 0:18 ` Aurélien Aptel
2012-02-02 0:52 ` Juanma Barranquero
2012-02-03 19:37 ` Aurélien Aptel
2012-02-04 8:14 ` Jan Djärv
2012-02-04 18:22 ` Aurélien Aptel
2012-02-06 0:18 ` Alp Aker
2012-02-06 0:24 ` Aurélien Aptel
2012-02-06 0:51 ` Alp Aker
2012-02-06 0:55 ` Aurélien Aptel
2012-02-06 1:14 ` Alp Aker
2012-02-06 11:27 ` Aurélien Aptel
2012-02-06 17:20 ` Aurélien Aptel
2012-02-12 11:19 ` Aurélien Aptel
2012-02-12 16:59 ` Stefan Monnier
2012-02-12 17:08 ` Leo
2012-02-12 17:29 ` Aurélien Aptel
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 17:55 Aurélien Aptel
2012-01-27 4:01 ` Leo
2012-01-27 10:25 ` Andreas Schwab
2012-01-27 13:02 ` Aurélien Aptel
2012-01-27 14:06 ` Andreas Schwab
2012-01-27 14:55 ` Aurélien Aptel
2012-01-27 15:53 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obtii1y4.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).