unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Olivier Sirven <the.slaa@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Patch for PHP5 support for etags
Date: Fri, 24 Feb 2012 11:36:06 +0100	[thread overview]
Message-ID: <87obsomsbt.fsf@gandalf.home.thebuble.org> (raw)
In-Reply-To: BANLkTi=1DO4ALzYtfAY9j2Q4VKgPNsmhPQ@mail.gmail.com

On 2011-04-26 14:36:35, Lennart Borgman wrote:
> On Tue, Apr 26, 2011 at 2:25 PM, Francesco Potortì <pot@gnu.org> wrote:
>>
>> Yes, I applied the patch.  I tested it and got strange results.  So I
>> need a php5 source file together with the expected results, so that I
>> can check it with more confidence.  Can you provide that, or point me to
>> someone else who can?
>
> Maybe some of those that have contributed to php-mode.el can?

I'm no php-mode.el contributor but I do code in PHP5 every single
working day using emacs for a long time now. 
I was previously forcing language detection to java in order to have
something usable even though not perfect.

I've just found out about this PHP5 patch for etags and just gave it a
try. As far as I can see it works just fine, all my declarations are
there and I don't see any strange results.

If you need any help getting this into the main code base I'd be glad to
help. But first I need to understand what you mean by "strange results"
so I can check whether or not I do have the same issue

-- 
Oliv




  reply	other threads:[~2012-02-24 10:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16 17:00 Patch for PHP5 support for etags james borden
2011-04-17 13:17 ` Francesco Potortì
2011-04-17 13:29   ` Lennart Borgman
2011-04-26 12:25     ` Francesco Potortì
2011-04-26 12:36       ` Lennart Borgman
2012-02-24 10:36         ` Olivier Sirven [this message]
2012-03-08  9:42           ` Olivier Sirven
2012-03-08 15:18             ` Stefan Monnier
2012-03-08 15:25               ` Olivier Sirven
2012-03-08 19:10             ` Francesco Potortì
2012-03-12 14:25               ` Olivier Sirven
2012-03-16 16:52               ` Olivier Sirven
2012-03-16 17:04                 ` Francesco Potortì
2012-03-19  8:14                   ` Olivier Sirven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obsomsbt.fsf@gandalf.home.thebuble.org \
    --to=the.slaa@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).