From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tromey@redhat.com>
Cc: Daniel Hackney <dan@haxney.org>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: cl-defstruct-based package.el, now with ert tests!
Date: Tue, 12 Mar 2013 16:03:05 +0400 [thread overview]
Message-ID: <87obeog70m.fsf@yandex.ru> (raw)
In-Reply-To: <87mwu9l6ju.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 11 Mar 2013 20:01:57 -0600")
Tom Tromey <tromey@redhat.com> writes:
> Daniel> The changes touch most of the code, but the overall structure of the
> Daniel> code has not changed significantly. Some parts of the code which were
> Daniel> questionable in the first place (such as using `tar-mode' to extract tar
> Daniel> archives) have been replaced with simpler alternatives. In the case of
> Daniel> tar, the file is simply downloaded to a temporary directory and
> Daniel> extracted using "tar xaf foo-1.2.3.tar".
>
> This sounds worse to me, since it means that now package installation
> has an external dependency. Previously this was not the case --
> intentionally.
Indeed, if that means that it won't work on vanilla Windows
installations, then this decision should be reversed.
The change looks good otherwise, I especially like the presence of tests.
next prev parent reply other threads:[~2013-03-12 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 1:03 cl-defstruct-based package.el, now with ert tests! Daniel Hackney
2013-03-12 2:01 ` Tom Tromey
2013-03-12 12:03 ` Dmitry Gutov [this message]
2013-03-12 18:13 ` Ted Zlatanov
2013-03-14 4:36 ` Daniel Hackney
2013-03-14 10:53 ` Stephen J. Turnbull
2013-03-14 12:11 ` Ted Zlatanov
2013-03-14 13:49 ` Stefan Monnier
2013-03-14 17:53 ` chad
2013-03-15 4:00 ` Daniel Hackney
2013-03-15 12:56 ` Stefan Monnier
2013-03-15 13:46 ` Eli Zaretskii
2013-03-20 18:01 ` Ted Zlatanov
2013-03-12 16:25 ` Daniel Hackney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obeog70m.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=dan@haxney.org \
--cc=emacs-devel@gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).