From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r116285: * lisp/emacs-lisp/lisp.el (lisp-completion-at-point): Symbols don't start Date: Thu, 13 Feb 2014 07:13:56 +0200 Message-ID: <87ob2br3vv.fsf@yandex.ru> References: <87zjm4tl2b.fsf@yandex.ru> <52F99C65.5010007@yandex.ru> <871tz995bl.fsf@web.de> <87ioslaepv.fsf@yandex.ru> <87vbwk60r2.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392268459 30268 80.91.229.3 (13 Feb 2014 05:14:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Feb 2014 05:14:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 13 06:14:26 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WDocz-0007sm-Cd for ged-emacs-devel@m.gmane.org; Thu, 13 Feb 2014 06:14:25 +0100 Original-Received: from localhost ([::1]:44265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDocy-0005CZ-IZ for ged-emacs-devel@m.gmane.org; Thu, 13 Feb 2014 00:14:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDocn-0005CD-P4 for emacs-devel@gnu.org; Thu, 13 Feb 2014 00:14:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDocf-0007Rg-Ao for emacs-devel@gnu.org; Thu, 13 Feb 2014 00:14:13 -0500 Original-Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:53481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDocf-0007RS-2p for emacs-devel@gnu.org; Thu, 13 Feb 2014 00:14:05 -0500 Original-Received: by mail-ee0-f44.google.com with SMTP id c13so4742493eek.17 for ; Wed, 12 Feb 2014 21:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=G+qvFBDPXRmdgKYBhKd0qMTXDJGXIgM5gdQdjisnw5Y=; b=BcJ3WhDtWGZnjNrDxlDcdHrlBKcoXpjNxi+mPfVzz5N2WlSELm9Ms/c9xyCaLVuId2 BRQJT3mbxqdlbdt4fuq6j9Nho1iZjFXa4MoA0mQHEcNsZSDrsq3aQrrqO/Ai/0/66glO 6W8fm4dQuO0t225YIbQQpgjmlBx/l0zUy7chM96ATsXpsloo1tCV3qAdEBXsNy8TBr30 Te7KjvUifFjq4Fd2xgzsinG2+hIkl40OFtl38sSJsnEV45HZ1HvU5lLqlV22LrtVyZfN o5Ju2DSUYsw/Uqqo6arw5xTX0YElbf8NhRey0q8Pa27CNrpZXkAKg7343jpVivNBiQ57 8iGQ== X-Received: by 10.14.205.3 with SMTP id i3mr8585776eeo.23.1392268444324; Wed, 12 Feb 2014 21:14:04 -0800 (PST) Original-Received: from axl (62-36-157.netrun.cytanet.com.cy. [62.228.36.157]) by mx.google.com with ESMTPSA id d9sm2380813eei.9.2014.02.12.21.14.02 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 12 Feb 2014 21:14:03 -0800 (PST) In-Reply-To: <87vbwk60r2.fsf@web.de> (Michael Heerdegen's message of "Wed, 12 Feb 2014 12:14:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169576 Archived-At: Michael Heerdegen writes: > callf, callf2, defsetf. Dunno if callf is popular enough, but I use it > very frequently. And `function', as Stefan already mentioned. Thanks. I've never used them, so far. > A situation where your patch doesn't work so well is in > quoted structures that actually are evaluated, like in `eval' or > `eval-after-load'. Here, completion is like before. We might add special handling for `eval-after-load' eventually, but `eval' should be more rare: I'd expect that most of the time it's passed a variable, not a straight quoted form. Although yes, mutual canceling of `eval' and one quote shouldn't be too hard to implement. > But after thinking more about it, situations where your patch is holding > back valid completions are quite rare in practice, so I can live with > that change. It would be good if the cl-callf2? case would work, > however. Ok, good. See the updated patch (in another email).