From: Dmitry Gutov <dgutov@yandex.ru>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r116285: * lisp/emacs-lisp/lisp.el (lisp-completion-at-point): Symbols don't start
Date: Thu, 13 Feb 2014 07:13:56 +0200 [thread overview]
Message-ID: <87ob2br3vv.fsf@yandex.ru> (raw)
In-Reply-To: <87vbwk60r2.fsf@web.de> (Michael Heerdegen's message of "Wed, 12 Feb 2014 12:14:57 +0100")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> callf, callf2, defsetf. Dunno if callf is popular enough, but I use it
> very frequently. And `function', as Stefan already mentioned.
Thanks. I've never used them, so far.
> A situation where your patch doesn't work so well is in
> quoted structures that actually are evaluated, like in `eval' or
> `eval-after-load'. Here, completion is like before.
We might add special handling for `eval-after-load' eventually, but
`eval' should be more rare: I'd expect that most of the time it's passed
a variable, not a straight quoted form. Although yes, mutual canceling
of `eval' and one quote shouldn't be too hard to implement.
> But after thinking more about it, situations where your patch is holding
> back valid completions are quite rare in practice, so I can live with
> that change. It would be good if the cl-callf2? case would work,
> however.
Ok, good. See the updated patch (in another email).
next prev parent reply other threads:[~2014-02-13 5:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WBHeS-0000wr-6k@vcs.savannah.gnu.org>
2014-02-06 13:41 ` trunk r116285: * lisp/emacs-lisp/lisp.el (lisp-completion-at-point): Symbols don't start Dmitry Gutov
2014-02-06 22:00 ` Stefan Monnier
2014-02-07 3:16 ` Michael Heerdegen
2014-02-07 13:22 ` Stefan Monnier
2014-02-11 3:43 ` Dmitry Gutov
2014-02-11 12:55 ` Michael Heerdegen
2014-02-11 14:47 ` Dmitry Gutov
2014-02-12 11:14 ` Michael Heerdegen
2014-02-13 5:13 ` Dmitry Gutov [this message]
2014-02-13 7:36 ` Michael Heerdegen
2014-02-13 13:33 ` Stefan Monnier
2014-02-14 3:48 ` Dmitry Gutov
2014-02-12 1:42 ` Stefan Monnier
2014-02-13 5:21 ` Dmitry Gutov
2014-02-13 12:56 ` Michael Heerdegen
2014-02-13 14:32 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob2br3vv.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).