From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.diffs,gmane.emacs.devel Subject: Re: map 6287979: Fix a false negative in `map-elt' with alists and values being nil Date: Sat, 25 Apr 2015 16:52:22 +0200 Message-ID: <87oamc6z15.fsf@petton.fr> References: <20150425100739.22272.85986@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4605296472944617144==" X-Trace: ger.gmane.org 1429973565 11354 80.91.229.3 (25 Apr 2015 14:52:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Apr 2015 14:52:45 +0000 (UTC) Cc: emacs-diffs@gnu.org, emacs-devel To: bruce.connor.am@gmail.com Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Sat Apr 25 16:52:35 2015 Return-path: Envelope-to: gnu-emacs-diffs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ym1Rb-0005zy-6Y for gnu-emacs-diffs@m.gmane.org; Sat, 25 Apr 2015 16:52:35 +0200 Original-Received: from localhost ([::1]:48590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym1Ra-00064L-Kt for gnu-emacs-diffs@m.gmane.org; Sat, 25 Apr 2015 10:52:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym1RW-00063d-JQ for emacs-diffs@gnu.org; Sat, 25 Apr 2015 10:52:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ym1RR-0006Cs-HO for emacs-diffs@gnu.org; Sat, 25 Apr 2015 10:52:30 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym1RR-0006CX-Dp for emacs-diffs@gnu.org; Sat, 25 Apr 2015 10:52:25 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A8D8E2083B for ; Sat, 25 Apr 2015 10:52:24 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Sat, 25 Apr 2015 10:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=8cg3YRAM1pbrhcwFS3BB+0weXOo=; b=baQFX t7SSfPQbJ8oMpsuJ1woTwOfqy8CoYEw69YnOlGcrkM7VpLbSrhOkgPYUCGRklY5v lCkI7FomGNP0UvR/sNmdjEcGS1rAK6AAg3sQ8neVpoeOQWACm5n/xqTPM6ceNwiT q74BQaUQpUBcJxZ/8aIAQYq4zzNVxkWmqdsf6g= X-Sasl-enc: W44OpBvpvL5FgpQatAO1j2RrtT6cirmq62ut+Mdz8MMY 1429973544 Original-Received: from blueberry (unknown [31.211.216.84]) by mail.messagingengine.com (Postfix) with ESMTPA id C387BC00015; Sat, 25 Apr 2015 10:52:23 -0400 (EDT) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.111.4.28 X-BeenThere: emacs-diffs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for Emacs changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Original-Sender: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.diffs:130062 gmane.emacs.devel:185873 Archived-At: --===============4605296472944617144== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Artur Malabarba writes: > Quick fix :-) > >> +(defun map--elt-list (map key &optional default) >> + "Return the element of the list MAP at the index KEY. >> +If KEY is not found, return DEFAULT which defaults to nil." >> + (let ((pair (assoc key map))) >> + (if pair >> + (cdr (assoc key map)) >> + default))) > > How about the following? > > (if pair (cdr pair) > default))) Thanks, I extracted `pair' and then forgot about it :) Nico =2D-=20 Nicolas Petton http://nicolas-petton.fr --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJVO6omAAoJECM1h6R8IHkQJzkIAL2p3u4n+jxIeg9sGTy2AbNi egXWtRbut3wJNBI10cBn0V02ZGz/e9Ym1Onh0ssT6T26qanR/0NOe3/A3CHUSwYW IkN3u1W/kXfq3sMuUH6TCnEi4MDmodfrgFBnhwRvYwXgCOqQRQtAQxdGpt/CXnJr JwNwO0PHLhrVA4OCNRDyR6KplrCnn3m6u1eOYfeKKLD6YFYfAKORxqUbp8dpoWNW wsgYaIW01QGAgl+YkCiM0RjWIclCd/IYv0TdkR3zY8jqsREdiPM14K0XdFlOFOh5 lwLXNL1mVhWQEXdvZwFXnTdRvPgiQmGANXWqFU2T/4mgCoFhLqRBpHyZwkgwlaA= =y1Dk -----END PGP SIGNATURE----- --=-=-=-- --===============4605296472944617144== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline