Re: map 6287979: Fix a false negative in `map-elt' with alists and values being nil

Re: map 6287979: Fix a false negative in `map-elt' with alists and values being nil

[Artur Malabarba]

Quick fix :-)

> +(defun map--elt-list (map key &optional default)
> +  "Return the element of the list MAP at the index KEY.
> +If KEY is not found, return DEFAULT which defaults to nil."
> +  (let ((pair (assoc key map)))
> +    (if pair
> +        (cdr (assoc key map))
> +      default)))

How about the following?

 (if pair (cdr pair)
   default)))

Re: map 6287979: Fix a false negative in `map-elt' with alists and values being nil

[Nicolas Petton]

[-- Attachment #1.1: Type: text/plain, Size: 529 bytes --]


Artur Malabarba writes:

> Quick fix :-)
>
>> +(defun map--elt-list (map key &optional default)
>> +  "Return the element of the list MAP at the index KEY.
>> +If KEY is not found, return DEFAULT which defaults to nil."
>> +  (let ((pair (assoc key map)))
>> +    (if pair
>> +        (cdr (assoc key map))
>> +      default)))
>
> How about the following?
>
>  (if pair (cdr pair)
>    default)))

Thanks, I extracted `pair' and then forgot about it :)

Nico
-- 
Nicolas Petton
http://nicolas-petton.fr

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]