* Re: master 692bce5: * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var
[not found] ` <E1ZrEYw-0001S1-CZ@vcs.savannah.gnu.org>
@ 2015-10-28 11:15 ` Michael Albinus
2015-10-28 12:56 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2015-10-28 11:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> branch: master
> commit 692bce5b9eccfae19ae2a5a23a9ccd8d6bf86076
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var
>
> * lisp/net/tramp-smb.el (tramp-smb-handle-directory-files): Use `delete-dups'.
I'm very sorry, but `delete-dups' does not exist in XEmacs
21.4. Therefore, I've reverted this commit.
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 692bce5: * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var
2015-10-28 11:15 ` master 692bce5: * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var Michael Albinus
@ 2015-10-28 12:56 ` Stefan Monnier
2015-10-28 14:34 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-10-28 12:56 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
> I'm very sorry, but `delete-dups' does not exist in XEmacs
> 21.4. Therefore, I've reverted this commit.
Then please use CL's delete-duplicates. Using add-to-list on
a let-local variable is really hideous.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 692bce5: * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var
2015-10-28 12:56 ` Stefan Monnier
@ 2015-10-28 14:34 ` Michael Albinus
0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2015-10-28 14:34 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> I'm very sorry, but `delete-dups' does not exist in XEmacs
>> 21.4. Therefore, I've reverted this commit.
>
> Then please use CL's delete-duplicates. Using add-to-list on
> a let-local variable is really hideous.
Done. It was a little bit hairy, beause `cl-delete-duplicates' has
different arguments in different (X)Emacs versions. But we need only the
version from XEmacs 21.4.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-28 14:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151028002558.5543.17132@vcs.savannah.gnu.org>
[not found] ` <E1ZrEYw-0001S1-CZ@vcs.savannah.gnu.org>
2015-10-28 11:15 ` master 692bce5: * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var Michael Albinus
2015-10-28 12:56 ` Stefan Monnier
2015-10-28 14:34 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).