From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Calling Lisp from undo.c's record_* functions Date: Tue, 17 Nov 2015 20:52:24 +0000 Message-ID: <87oaesmjqv.fsf@russet.org.uk> References: <83r3jpc2of.fsf@gnu.org> <87h9kkbz6k.fsf@russet.org.uk> <87d1v8bsbf.fsf@russet.org.uk> <83a8qcbn2r.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447793579 17096 80.91.229.3 (17 Nov 2015 20:52:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2015 20:52:59 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 17 21:52:50 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZynF8-0002sh-Ds for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 21:52:46 +0100 Original-Received: from localhost ([::1]:60613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZynF7-0006G6-RA for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 15:52:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZynEu-0006Eq-7K for emacs-devel@gnu.org; Tue, 17 Nov 2015 15:52:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZynEt-0002sb-D9 for emacs-devel@gnu.org; Tue, 17 Nov 2015 15:52:32 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:35646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZynEo-0002sP-LW; Tue, 17 Nov 2015 15:52:26 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1ZynEn-0002gy-FR; Tue, 17 Nov 2015 20:52:25 +0000 Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZynEn-00043Q-CP; Tue, 17 Nov 2015 20:52:25 +0000 In-Reply-To: <83a8qcbn2r.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Nov 2015 18:35:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194668 Archived-At: Eli Zaretskii writes: >> There are only 7 calls to record_insert so changing the so record_insert >> is *always* before would be possible. > > Did you look at insert_from_gap? AFAIU, it assumes that the gap > position stays put during the call to record_insert. If that can call > Lisp or GC, that assumption is false. I didn't look at this. I'm learning C as I go, so I wouldn't put too much weight behind my own conclusions even if I had. >> Big change to make at this point in the release cycle. > > No, I don't think so. We still have several months to go. > > Btw, could you perhaps write a short description of this change and > its effects in the Lisp level for etc/NEWS? I see there's not a word > about this there. Bonus points if you also update the ELisp manual. I will do. Do I get a prize when I get enough points? Phil