Re: Calling Lisp from undo.c's record_* functions

[phillip.lord@russet.org.uk (Phillip Lord)]

Eli Zaretskii <eliz@gnu.org> writes:
>> There are only 7 calls to record_insert so changing the so record_insert
>> is *always* before would be possible.
>
> Did you look at insert_from_gap?  AFAIU, it assumes that the gap
> position stays put during the call to record_insert.  If that can call
> Lisp or GC, that assumption is false.

I didn't look at this. I'm learning C as I go, so I wouldn't put too
much weight behind my own conclusions even if I had.


>> Big change to make at this point in the release cycle.
>
> No, I don't think so.  We still have several months to go.
>
> Btw, could you perhaps write a short description of this change and
> its effects in the Lisp level for etc/NEWS?  I see there's not a word
> about this there.  Bonus points if you also update the ELisp manual.

I will do. Do I get a prize when I get enough points?

Phil