unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Iñigo Serna" <inigoserna@gmail.com>
To: "Clément Pit--Claudel" <clement.pit@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Advicing select-windows, shr rendering, and per-buffer-theme package
Date: Fri, 18 Mar 2016 17:45:02 +0100	[thread overview]
Message-ID: <87oaabybu9.fsf@gmail.com> (raw)
In-Reply-To: <56EC0530.1050503@gmail.com>

Hi,

Clément Pit--Claudel <clement.pit@gmail.com> writes:

> Do you need to change theme for temporary buffers? Usually these have a name that starts with a space; did you make sure to blacklist them?

I think I checked for them, but not, the regular expression I used didn't
include temporary buffers.
Checking for them before changing theme helps a lot!

> Another idea; do you need to change the theme per buffer, or per buffer displayed in a window? If the latter, then you could ensure that buffer themes are only changed if a buffer is actually shown on screen.

This is useful too.

Finally, combining both suggestions solve the problem. There are some
flickering in some rare cases but most of them have disappeared.

  (when (and (not (string-prefix-p " " (buffer-name buffer)))
             (get-buffer-window buffer))
      ...)

Thanks,
Iñigo Serna



  reply	other threads:[~2016-03-18 16:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 11:04 Advicing select-windows, shr rendering, and per-buffer-theme package Iñigo Serna
2016-03-18 13:38 ` Clément Pit--Claudel
2016-03-18 13:40 ` Clément Pit--Claudel
2016-03-18 16:45   ` Iñigo Serna [this message]
2016-03-18 17:45     ` Clément Pit--Claudel
2016-03-18 20:17       ` Iñigo Serna
2016-03-18 22:07         ` raman
2016-03-18 13:55 ` raman
2016-03-18 15:21   ` Stefan Monnier
2016-03-18 16:28     ` raman
2016-03-18 16:47       ` Stefan Monnier
2016-03-18 22:13       ` Iñigo Serna
2016-03-18 22:48         ` raman
2016-03-18 17:04     ` Iñigo Serna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oaabybu9.fsf@gmail.com \
    --to=inigoserna@gmail.com \
    --cc=clement.pit@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).