Re: [PATCH v5] Add systemd socket launching support

[Matthew Leach <matthew@mattleach.net>]

[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]

Hi Eli,

Thanks for taking another look at this.

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Matthew Leach <matthew@mattleach.net>
>> Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA>
>> Date: Sun, 10 Apr 2016 15:06:54 +0100
>> 
>> Here is a new version of the systemd integration & socket-launching
>> patches.  The main change in this series is providing an interface for
>> other socket-launching applications to be integrated, namely
>> `set_external_socket_descriptor' in process.c.
>> 
>> Feedback & comments welcome!
>
> Thanks, I pushed it to the master branch.
>
> I think it would make sense to add this feature to the list in
> EMACS_CONFIG_FEATURES (see the configure script for how we generate
> that list).

Ah I didn't know about that list.  Please see the attached patch which
should fix that.

> A few minor comments, for the future:
>
>  . Be consistent in how you quote symbols in the log entries.  In this
>    submission, you sometimes quoted `like this', sometimes 'like
>    this', and sometimes left the symbols unquoted.  Pick one style and
>    stick to it.
>
>  . The way to call out a function name is 'function' (with quotes).
>    The GNU Coding Standards frown upon using function(), which looks
>    like a call to the function with no arguments, not what you mean.

Thank you for the feedback.
-- 
Matt

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-libsystemd-to-EMACS_CONFIG_FEATURES.patch --]
[-- Type: text/x-diff, Size: 1586 bytes --]

From 39b077d3f3cb84867ef4a177654c53e5ca8f604c Mon Sep 17 00:00:00 2001
From: Matthew Leach <matthew@mattleach.net>
Date: Sun, 17 Apr 2016 12:07:19 +0100
Subject: [PATCH] Add libsystemd to EMACS_CONFIG_FEATURES

* configure.ac: Add LIBSYSTEMD to EMACS_CONFIG_FEATURES and print a
  message at the end of configure stating whether Emacs will be build
  with libsystemd support.
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 54e9ec5..86b16b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5200,7 +5200,7 @@ emacs_config_features=
 for opt in XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS \
   GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT \
   LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS X_TOOLKIT X11 NS MODULES \
-  XWIDGETS; do
+  XWIDGETS LIBSYSTEMD; do
 
     case $opt in
       NOTIFY|ACL) eval val=\${${opt}_SUMMARY} ;;
@@ -5247,6 +5247,7 @@ AS_ECHO(["  Does Emacs use -lXaw3d?                                 ${HAVE_XAW3D
   Does Emacs use -lm17n-flt?                              ${HAVE_M17N_FLT}
   Does Emacs use -lotf?                                   ${HAVE_LIBOTF}
   Does Emacs use -lxft?                                   ${HAVE_XFT}
+  Does Emacs use -lsystemd?                               ${HAVE_LIBSYSTEMD}
   Does Emacs directly use zlib?                           ${HAVE_ZLIB}
   Does Emacs have dynamic modules support?                ${HAVE_MODULES}
   Does Emacs use toolkit scroll bars?                     ${USE_TOOLKIT_SCROLL_BARS}
-- 
2.8.0