From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Recent commit modifying mark-whole-buffer (master/aeb613ea95b7970e66d663ec5cba54e9ec0528fa)
Date: Sat, 30 Apr 2016 16:34:15 +0200 [thread overview]
Message-ID: <87oa8rp3mg.fsf@gnus.org> (raw)
In-Reply-To: <jwvy47v5gey.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Sat, 30 Apr 2016 10:19:15 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Yup. Like I said in the bug report, I think the solution here is to
>> have read-from-minibuffer not apply the default face if there are any
>> faces specified on the prompt string.
>
> "Not apply" sounds wrong. Better do an "append" so the face properties
> provided to read-from-minibuffer get merged with the
> minibuffer-prompt face.
That was my original idea, but I think Drew is right that if somebody
has said
(read-from-minibuffer (propertize "foo" 'face 'bold))
it's pretty unlikely that they want `bold' merged with the blue face...
I mean, they can also bind `minibuffer-prompt-properties', but
that's... not very convenient, since it has other, necessary
properties, or redefine the minibuffer-prompt face, but that's also not
what you want to do for a single prompt.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-04-30 14:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 20:24 Recent commit modifying mark-whole-buffer (master/aeb613ea95b7970e66d663ec5cba54e9ec0528fa) Kaushal Modi
2016-04-28 21:40 ` Lars Ingebrigtsen
2016-04-28 22:25 ` Stephan Mueller
2016-04-29 6:45 ` Eli Zaretskii
2016-04-29 12:23 ` Lars Ingebrigtsen
2016-04-29 12:41 ` Eli Zaretskii
2016-04-29 12:48 ` Lars Ingebrigtsen
2016-04-29 13:28 ` Eli Zaretskii
2016-04-29 14:28 ` Lars Ingebrigtsen
2016-04-29 17:06 ` Eli Zaretskii
2016-04-29 17:43 ` Kaushal Modi
2016-04-29 18:33 ` Eli Zaretskii
2016-04-30 7:51 ` John Wiegley
[not found] ` <<87y47w5w0p.fsf@gnus.org>
[not found] ` <<83bn4swdif.fsf@gnu.org>
2016-04-29 19:28 ` Drew Adams
2016-04-29 20:00 ` Eli Zaretskii
2016-04-29 20:18 ` Lars Ingebrigtsen
2016-04-29 20:24 ` Eli Zaretskii
2016-04-29 20:30 ` Lars Ingebrigtsen
2016-04-30 14:19 ` Stefan Monnier
2016-04-30 14:34 ` Lars Ingebrigtsen [this message]
2016-04-30 14:41 ` Stefan Monnier
2016-04-30 14:51 ` Lars Ingebrigtsen
[not found] ` <<87eg9ouq24.fsf@gnus.org>
[not found] ` <<83shy4ups9.fsf@gnu.org>
2016-04-29 21:48 ` Drew Adams
2016-04-30 5:23 ` Eli Zaretskii
[not found] ` <<83r3dnvfed.fsf@gnu.org>
2016-04-30 19:06 ` Drew Adams
[not found] ` <<83y47wuqvg.fsf@gnu.org>
2016-04-29 21:49 ` Drew Adams
2016-04-30 5:24 ` Eli Zaretskii
[not found] ` <<83pot7vfch.fsf@gnu.org>
2016-04-30 19:14 ` Drew Adams
2016-04-30 14:15 ` Stefan Monnier
2016-04-30 19:18 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa8rp3mg.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).