From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.devel Subject: Re: bug#21072: Brave new mark-defun (and a testing tool) Date: Wed, 29 Mar 2017 08:34:06 +0200 Message-ID: <87o9wkoald.fsf@jane> References: <87o9ydrzkr.fsf@mbork.pl> <87mvdriuss.fsf@mbork.pl> <87bmu6icea.fsf@mbork.pl> <87wpctgieu.fsf@mbork.pl> <52e67f43-edcf-09e3-5fd6-6079763fd234@yandex.ru> <87tw7wh9sf.fsf@mbork.pl> <87k28sdka6.fsf@jane> <87efyze00g.fsf@jane> <87bmu2eoji.fsf@jane> <87wpcpw61w.fsf@jane> <83o9xdghmc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490769292 6723 195.159.176.226 (29 Mar 2017 06:34:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Mar 2017 06:34:52 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 26.0.50 Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, 21072@debbugs.gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 29 08:34:48 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ct7Bs-0000wf-QR for ged-emacs-devel@m.gmane.org; Wed, 29 Mar 2017 08:34:45 +0200 Original-Received: from localhost ([::1]:56875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ct7Bx-0002TB-5w for ged-emacs-devel@m.gmane.org; Wed, 29 Mar 2017 02:34:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ct7BR-0002Su-AC for emacs-devel@gnu.org; Wed, 29 Mar 2017 02:34:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ct7BQ-0004MY-Ih for emacs-devel@gnu.org; Wed, 29 Mar 2017 02:34:17 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:50832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ct7BL-0004Ls-9G; Wed, 29 Mar 2017 02:34:11 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 65AC1E69D3; Wed, 29 Mar 2017 08:34:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gcbe4GnTvcuh; Wed, 29 Mar 2017 08:34:05 +0200 (CEST) Original-Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 4258FE6819; Wed, 29 Mar 2017 08:34:05 +0200 (CEST) In-reply-to: <83o9xdghmc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.110.48.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213484 Archived-At: On 2017-03-07, at 17:46, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Date: Fri, 17 Feb 2017 09:54:51 +0100 >> Cc: 21072@debbugs.gnu.org, emacs-devel@gnu.org >> >> OK, so I have renamed it and expanded the docstring. I attach >> a corrected patch (the second one, the first one is the same as before). >> >> Is there anything else I can do before we may apply this patch and >> consider bug#21072 fixed? > > Thanks, this looks good, but please move the tests to lisp-tests.el, > to keep our conventions wrt test names. > > Then this could go in. I just pushed it to a branch, forgetting about this email. I'll fix it and report back. For now, I deleted the branch I pushed; I'll pish it again as soon as I correct this. Thanks, -- Marcin Borkowski