From: Tom Tromey <tom@tromey.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: moving some indentation tests
Date: Thu, 06 Apr 2017 09:53:50 -0600 [thread overview]
Message-ID: <87o9w94jn5.fsf@pokyo> (raw)
In-Reply-To: <CAM-tV--Qhn3JHNPu7riCjx=9BP8HO6VfOHbaJrnqdy1HVxwqUg@mail.gmail.com> (Noam Postavsky's message of "Thu, 6 Apr 2017 10:33:21 -0400")
>>>>> "Noam" == Noam Postavsky <npostavs@users.sourceforge.net> writes:
>> How about picking up a name of an existing source file that is somehow
>> related to the tests?
Noam> Yeah, shouldn't the js indentation tests go in lisp/progmodes/js-tests.el, etc?
The current tests are just a bunch of files that should not be changed
by re-indentation. This has the nice property that a new test can be
written by just dropping a file in the correct directory.
It's possible of course to split these by major mode. But, that's
significantly more work, both for moving the tests and for writing new
tests, and furthermore, IMO of course, doesn't provide any real benefit.
Tom
next prev parent reply other threads:[~2017-04-06 15:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 9:47 moving some indentation tests Tom Tromey
2017-04-02 11:46 ` Michael Albinus
2017-04-02 16:06 ` Tom Tromey
2017-04-02 18:16 ` Michael Albinus
2017-04-02 15:53 ` Eli Zaretskii
2017-04-02 15:58 ` Dmitry Gutov
2017-04-02 16:05 ` Tom Tromey
2017-04-02 20:31 ` Phillip Lord
2017-04-02 21:02 ` Noam Postavsky
2017-04-03 11:11 ` Phillip Lord
2017-04-03 13:20 ` Noam Postavsky
2017-04-03 16:39 ` Phillip Lord
2017-04-03 20:38 ` Noam Postavsky
2017-04-07 15:51 ` Phillip Lord
2017-04-07 16:06 ` Noam Postavsky
2017-04-06 3:28 ` Tom Tromey
2017-04-06 14:11 ` Eli Zaretskii
2017-04-06 14:32 ` Michael Albinus
2017-04-06 14:33 ` Noam Postavsky
2017-04-06 15:53 ` Tom Tromey [this message]
2017-04-07 15:54 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9w94jn5.fsf@pokyo \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).