From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.devel Subject: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Date: Wed, 21 Feb 2018 10:30:24 -0800 Message-ID: <87o9kii4an.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519237759 16704 195.159.176.226 (21 Feb 2018 18:29:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Feb 2018 18:29:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 21 19:29:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eoZ8k-0003pn-L0 for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 19:29:15 +0100 Original-Received: from localhost ([::1]:34186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoZAm-0001JC-UZ for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 13:31:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoZAg-0001Ix-22 for emacs-devel@gnu.org; Wed, 21 Feb 2018 13:31:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoZAc-0004r9-1b for emacs-devel@gnu.org; Wed, 21 Feb 2018 13:31:14 -0500 Original-Received: from vps28183.inmotionhosting.com ([23.235.221.66]:33566) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eoZAb-0004HB-No for emacs-devel@gnu.org; Wed, 21 Feb 2018 13:31:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cochranmail.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sxnenhZ5yT0aUdPZbpCatCVm+L7FFJuFaDwxSD9za8Q=; b=je97X5rwE1aPIDW5CIzoc8AUEs k7FxYX8KWmMZhxmnzVL3nv9kHHNonCejGhLvIRrYp+jqOMxXb81w3oy81PB2KZGgYBo70QqOhHnwN YG9sf8PuJBX8aAVPpBmFxsJaWcP6ay+FRCZBoEEF6lkP+yIZ+wrqdY+Ieair16Y0V9qQ6j5o/ba+K R7YoOoN7DK2S3wx8jETmvsqPwMZ/vUkEcr13WxMpG9Or0A6uUG1GYcUtJQhgJPiMAoAEKuQ+fJpTp cEsKNND3ZU3q93JyjLGw8Ao0CemrjaRgnQ6ohItrRrYzjbOI5XIQUv8c+KFkuASmMUEkrzxWiJbyO ChgjWOkA==; Original-Received: from 131-191-86-130.as.clicknet.org ([131.191.86.130]:35634 helo=SoraLaptop) by vps28183.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1eoZ9v-00078x-QT for emacs-devel@gnu.org; Wed, 21 Feb 2018 10:30:27 -0800 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps28183.inmotionhosting.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - cochranmail.com X-Get-Message-Sender-Via: vps28183.inmotionhosting.com: authenticated_id: robert@cochranmail.com X-Authenticated-Sender: vps28183.inmotionhosting.com: robert@cochranmail.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 23.235.221.66 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222963 Archived-At: Hello emacs-devel! Now that the byte-compile-error-on-warn patch was merged (thanks by the way!), this is the next step: I've marked most every file in lisp/ that currently byte-compiles without warnings with 'byte-compile-error-on-warn: t' in its file local variables. I did an absolutely from-scratch build and it completed succesfully, as well as running the full test suite with no significant errors. I may have missed some files that should have been marked, but I took care to *not* mark any files that had errors in them. The intended goal is to not break the build, but have files that are already warning-free not grow warnings. Files that still have warnings can be fixed as we go, ala lexical-binding. So, it's my understanding that there are some portions of what's in emacs.git - org-mode being the prominent example in my mind - are simply merges of a separate repository into emacs.git. Will it be necessary to submit patches to the 'child' repositories rather than here? If so, how can I find out which files are from said repositories? This patch is rather large - the email patch form is 600k. The reason for this is that I've touched quite a number of files - over 1,000 according to the Gitlab interface. Thusly, I'm opting to link to the commit from my copy of the repository rather than attach directly: https://gitlab.com/RobertCochran/emacs/commit/f8446de4525910cf24dab7635124c3227c1ed1be Gitlab also has the email form for convenience: https://gitlab.com/RobertCochran/emacs/commit/f8446de4525910cf24dab7635124c3227c1ed1be.patch Comments, suggestions, concerns, all that good stuff warmly welcomed. Thanks, -- ~Robert Cochran GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE E7B9 EC9A 872C 41B2 77C2