From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master babe0d4: Rearrange definition of zerop in subr.el Date: Thu, 12 Jul 2018 18:34:32 +0300 Message-ID: <87o9fc79iv.fsf@tcd.ie> References: <20180711060905.55C0D209E0@vcs0.savannah.gnu.org> <87efg9c1mv.fsf_-_@red-bean.com> <877em1zog8.fsf@tcd.ie> <45d81138-5873-40af-c21b-125e9f0bd0b8@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531409786 8096 195.159.176.226 (12 Jul 2018 15:36:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jul 2018 15:36:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Karl Fogel , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 12 17:36:22 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdddl-00021L-V3 for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 17:36:22 +0200 Original-Received: from localhost ([::1]:60812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fddft-0001b3-4I for ged-emacs-devel@m.gmane.org; Thu, 12 Jul 2018 11:38:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fddcM-000841-PD for emacs-devel@gnu.org; Thu, 12 Jul 2018 11:34:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fddcJ-0002a9-NW for emacs-devel@gnu.org; Thu, 12 Jul 2018 11:34:54 -0400 Original-Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:37721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fddcJ-0002Wm-Gg for emacs-devel@gnu.org; Thu, 12 Jul 2018 11:34:51 -0400 Original-Received: by mail-wm0-x22e.google.com with SMTP id n17-v6so6544305wmh.2 for ; Thu, 12 Jul 2018 08:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zbRnFtQYbFMtZB0ee8Qebj7HwCv/Epdqtw/ukbrz5Nc=; b=Dy8xDZvmGHr9cCJlh25LUq2zQuac/KKgOg3nQO6aHTrSMazNS3I242Fr5jttVR1FXt I7//vRRDJuD/l+saTHQNyQMufUfUb3pEgejyBEC1uN0IB6Y7T/EkF4tm/d4Wqw1UwK2b KA47eyRaSbIxeXhUpa91fDGyb6XA+TUZlLlRH5TGlKxE3jEbLCWDqm3TTVhNx9VLY0Qv 8thBTknStNbLOvzKkPgdnMOV43Qu7qwJS4t5EHiZUGdT38Xsn5TXsmrVxqHRtrN7srv+ q+x3fdw8HcCqzN/hEa8pl3xdG2Q56ANtYwKYqO15pBpzKblGxdqaq554WiwI24KZcnTB hwlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zbRnFtQYbFMtZB0ee8Qebj7HwCv/Epdqtw/ukbrz5Nc=; b=WPNIm14Zy1m7gQNnAXzKG1vicCmnY3zDHN1mcy8nHk/BxLllEeycK0HqSZHGwVow66 5C7R0RGET4InVLWfJesuIVbRbxIApHPZUqbTh3xidUXGmKF9dPw86vzJ4jlPNxLGIKBa AIJoO6qnvuqSx7ls7y3wdw+wUbBUFWXJOnJ43i4vTA8ua01fl8BodAgT7rXnurcUx8Hq OAkCJ6IoVQXtl+4bmoWBNoBNd2Rd5yASvt7J8BW7L77LFXLhnMSxwJOi5dxSJjTrZC49 mVbbkZEBoh544zCQyXflUSnN21PjnC7OkIUgwfNoCVV29QP54p847pe0jkgHpMdVM7Vx aHFw== X-Gm-Message-State: AOUpUlHJn9R2jdUzEtJXwxV1ERcsUI1OLeVtkLZdOhQJ0H/So5P/oIL5 IJwvf7HW2J+xA5UVy3SVTEBptA== X-Google-Smtp-Source: AAOMgpeDiB9U3bQBRuhzs6jDq/9LvFOX9TVhruukZ2KSRm8O3Khj7RzJRzIa2SHF1Oim1Z/aNYPdQw== X-Received: by 2002:a1c:6d94:: with SMTP id b20-v6mr1698434wmi.28.1531409689646; Thu, 12 Jul 2018 08:34:49 -0700 (PDT) Original-Received: from localhost (adsl-96.91.140.91.tellas.gr. [91.140.91.96]) by smtp.gmail.com with ESMTPSA id s184-v6sm4455181wmf.5.2018.07.12.08.34.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Jul 2018 08:34:48 -0700 (PDT) In-Reply-To: <45d81138-5873-40af-c21b-125e9f0bd0b8@cs.ucla.edu> (Paul Eggert's message of "Wed, 11 Jul 2018 10:33:36 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227276 Archived-At: Paul Eggert writes: > Basil L. Contovounesios wrote: > >> Would adding a comment along the following lines be welcome? > > Yes, it might help avoid future such problems. I installed it (after removing > some of the excessive text in the commit message and fixing the attribution). Thanks. Re: the attribution, I must have misinterpreted the following excerpt from CONTRIBUTE: One way to identify revisions is by quoting their summary line. Another is with an action stamp - an RFC3339 date followed by ! followed by the committer's email - for example, "2014-01-16T05:43:35Z!esr@thyrsus.com". I initially paired the git-log fields CommitDate and Commit, rather than AuthorDate and Author, respectively (hence your email in place of mine), whereas you paired CommitDate and Author. I realise this is probably inconsequential or overly pedantic, but I'm nevertheless curious whether there's any difference or preference. -- Basil