From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 18:27:24 +0000 Message-ID: <87o95yq06r.fsf@tcd.ie> References: <8736nbip4l.fsf@tcd.ie> <875zs6rfdx.fsf@tcd.ie> <87pnqehlc0.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157719"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 19:28:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8UKQ-000esg-A0 for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 19:28:10 +0100 Original-Received: from localhost ([127.0.0.1]:46706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8UKP-0007jT-Bt for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 14:28:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8UJn-0007hp-W8 for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:27:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8UJm-0005Zn-WD for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:27:31 -0400 Original-Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:37258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8UJl-0005Xy-26 for emacs-devel@gnu.org; Mon, 25 Mar 2019 14:27:29 -0400 Original-Received: by mail-ed1-x536.google.com with SMTP id v21so8448804edq.4 for ; Mon, 25 Mar 2019 11:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1q+U4ew7Kb2xrV1dmrTOiv3IPJqj8YIS2BZ7mxbwr4o=; b=roXBU2z/ukuKg04kqoPaZAl+nq+32aG/yvraxeI1vPT94kgIRibCGM6W3oR3qmdzEv vrtu/Ih3mnUM1+ByqX0X4WHPi7JrewFwE6ndOGhQKFjv53dPsBnSYHzuQx4H27b6GaKN T0bBJcnpAUJ1iyiIXzhpjrJ89P6SLKFRLPhuVzGIO7xl7RQGtB39je3DhQGawOkJYANj D0+pCcz3Vy27g+/syxXZed1nPJqzyK7ZnisA6k3F27FI2UolPnkwcw+oBTbsz4R8XN2u qotYMdprvQpwrNOGrk6fR+9BMYo0OiagoIlu0Oq0GsWSpdMqGeGCtPCVKPnAorul6MGf yLuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1q+U4ew7Kb2xrV1dmrTOiv3IPJqj8YIS2BZ7mxbwr4o=; b=rcFlakzBtX+83KOt9rgwPGcA4jS4qEuvU/evZHYiI00N2dGfq8b5OC8meSvk2ADKkF HR2Jixqtew2s0E+1KAIR44Im8YsLgcwb6uGhPzp0/LwCEa75l0VkpPH01JUdj8oXqFGd /3U6OCtc1Vq6FN6on+qi+Kvwy6BhnYHpBFfFnDL0gcxabz48X2DshFwYEnRjgLlz3x0f jo4GBEB+/pSVyW/oJHQevDpypHiOX5iDzdOYS5PdZsKn+ATZpKlTzOWsZz1Qa6VUEqZb S19Zuzn3jAHTAWyIPsVmNj11eKYs8J8zGdgbFhDGZvkoNeLHuHbqOcO6g9ce2h+4mfKY FDyQ== X-Gm-Message-State: APjAAAW+O8h6JAlGW5ozUfhmSB30ZoB3Ny1RqRnk++goIq/d1qGw/g3g ma5mLsC0CAx8AUbwD/LWF86RYw== X-Google-Smtp-Source: APXvYqxaU/DqHZy7QPjrsZiBkL72WHKybCJRExcFF77PAHdvIOnZK1aKK9F3c1SSJoVLr4tRutKSmg== X-Received: by 2002:a50:eac9:: with SMTP id u9mr6863963edp.159.1553538446677; Mon, 25 Mar 2019 11:27:26 -0700 (PDT) Original-Received: from localhost ([134.226.214.210]) by smtp.gmail.com with ESMTPSA id z9sm3577179ejg.36.2019.03.25.11.27.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 25 Mar 2019 11:27:26 -0700 (PDT) In-Reply-To: <87pnqehlc0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 25 Mar 2019 11:15:27 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::536 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234723 Archived-At: Eric Abrahamsen writes: > On 03/25/19 18:13 PM, Basil L. Contovounesios wrote: >> Lars Ingebrigtsen writes: >> >>> "Basil L. Contovounesios" writes: >>> >>>> + (unless (or (gnus-data-pseudo-p datum) >>>> + (<= (gnus-data-number datum) 0) >>> >>> I'm against using `unless' on complex logic -- many people get confused >>> when reading it in my experience. >> >> Fair enough. >> >>> The rest looks OK. >> >> Thanks. I will wait a few more days for people to comment and push the >> rest of the patch if there are no serious objections. > > If I end up backing out the hash-table changes, will this patch still > apply correctly? The original patch I sent will conflict with the hunks where you added docstrings to gnus-dup-{list,hashtb} and switched from obarray to hash-table operations. It would be easy for me to resolve these minor conflicts, but if that's going to get in your way of more pressing work, then I'll hold off. (That's not to say I think you should revert the hash-table changes.) Thanks, -- Basil