unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 66db7b2 1/2: Always include the number of unexpected results here too
Date: Sat, 27 Jul 2019 12:58:18 +0100	[thread overview]
Message-ID: <87o91fvgdh.fsf@tcd.ie> (raw)
In-Reply-To: <m3imrn94fa.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 12:07:21 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> larsi@gnus.org (Lars Ingebrigtsen) writes:
>>
>> Should this be updated as follows?
>>
>> diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el
>> index 272fd4aec2..c659e4f3fc 100644
>> --- a/lisp/emacs-lisp/ert.el
>
> Looks like Paul made a similar change to fix this already...

Indeed (thanks Paul), but what about this question:

>> What about ert-run-tests-interactively and
>> ert--results-format-expected-unexpected?

Do these need to be updated for consistency with the other reporting
functions?

Thanks,

-- 
Basil



  reply	other threads:[~2019-07-27 11:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190726075902.16162.83489@vcs0.savannah.gnu.org>
     [not found] ` <20190726075904.0A44C20C06@vcs0.savannah.gnu.org>
2019-07-26 15:19   ` [Emacs-diffs] master 66db7b2 1/2: Always include the number of unexpected results here too Basil L. Contovounesios
2019-07-26 15:25     ` Basil L. Contovounesios
2019-07-27 10:07     ` Lars Ingebrigtsen
2019-07-27 11:58       ` Basil L. Contovounesios [this message]
2019-07-27 12:04         ` Lars Ingebrigtsen
2019-07-27 14:23         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o91fvgdh.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).