From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 b3e2073 4/4: Fix subproc listening when setting filter to non-t (Bug#36591) Date: Thu, 22 Aug 2019 21:12:15 +0200 Message-ID: <87o90hypyo.fsf@gmx.de> References: <20190725223622.30077.68533@vcs0.savannah.gnu.org> <20190725223624.B5F4920C06@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46451"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 22 21:16:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0sZs-000Bym-1A for ged-emacs-devel@m.gmane.org; Thu, 22 Aug 2019 21:16:56 +0200 Original-Received: from localhost ([::1]:47366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0sZp-0006DF-SG for ged-emacs-devel@m.gmane.org; Thu, 22 Aug 2019 15:16:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40924) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0sVX-0006Cq-Tz for emacs-devel@gnu.org; Thu, 22 Aug 2019 15:12:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0sVU-0005W9-SP for emacs-devel@gnu.org; Thu, 22 Aug 2019 15:12:26 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:34485) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0sVT-0005U6-UB for emacs-devel@gnu.org; Thu, 22 Aug 2019 15:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566501136; bh=36+LgYYK+SAEwSZQN9Kt4A5P3NAJJHTytejjK9G8PSQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=koIoN9O9jUbHEy5KUhx6B2FkTX0JjTrLvEWv+5rrGkb+oIZ/f9l6aDknx1mm4EnV3 9c7mt13FWbRdUddD6B3Qgd0Xb71wpxlZb6Q/vYJAQkxXqkE2fKUC8hHJePdv1qsULI t2P9PZMBgt96MNEdRkaradd1I0qZrGGHl5V+FgVU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.60.135]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MLA45-1i19UH2Z6H-000KNj; Thu, 22 Aug 2019 21:12:16 +0200 In-Reply-To: <20190725223624.B5F4920C06@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Thu, 25 Jul 2019 18:36:24 -0400 (EDT)") X-Provags-ID: V03:K1:WNkKJHPg7zb7s7Sa8B6CO3EpFanQ94PWADTUYYgztu3RirlAskT kA6LKnHm++aRsM1z8DZA4pxFJxUqxuHhQvA2bbcbM3zb3NavlZmoKR7/4a2rpdazWkzT+K8 q3bXODzKp12MKhyoQ9kOz5Gy5BbTDyhPn0cOBZIOTCsXcAg+fOk3J0fZ1gEk9jbeI+R/WXW g/4JEDfMWQwQBioB2+B8A== X-UI-Out-Filterresults: notjunk:1;V03:K0:g06qowBbvHU=:YGHrX0ZhlQi6WMoYlqp6K7 tU9s1lVaaRcaFMspmx8jl92VlrWRgKRpTncgZrMcfEaEMWkCwLzz8BmgnVIRQcudo8exBp/wn rXdvySyD75UKCHFlbodgZ0io2IMy00eNKsUT9bBUNggfqcZ4LoT2DXomn7xLW1OY8p0JETpWU zoivLWDc5rVIijSJaYNdY2Q3+CsizaFX4ETVnUq5pn6S66nXd26i1NFt4+aSRpkdO421fxzVw LGG5kRCVMIY1MWVl/tdXtWEcMYs3sxzkbd58tXF+w3EeT5Ftkh/EQ/yqFeraQhA180wRFKXfg VmJvjBY1efV+O/m6iv/Yor0DB0fJZwrQY9IkbTG7hELiiz4NtRuBzhKo1Y6ZENnKuMUB8zK0t xg8l0E1+omM2/xTBaEfRWeVV+UO7cBsOfvrYzf/qjE5NsJh92rMy/MbrCzfAxXRaIJllNeAC0 tkn92KkTn0/tS2kkL9DFp2mJKVloErEWNrOK24RXKeyfk7UCJg4TMIYkzmogtCjXA41G4Cjz9 J6OOYP9Z9lFr35mxftJqNrWm1tdUiFls5cLHunLfW9pDUhAEXKCoapGaKwwD/e2i9xe+D056V I28i/yX8rC8h8XkGNZAtKV91MiHUiYpRfwUFNFwmyVHLDtZ3oJkUcAArTvGcLkg31Ai4h3bW1 dnreSOCLh3lSx//yS+qH7qYbfte8kMKPWIEDPx/wmJZqumHiNkY8X2ppuYS0WidEC9upK0y0Q BU2Is1p2Kzhkg7cP2EDQDhuQjS4FL3YGjsa596w5q+gIdR1eAi2rB0OdqTGjL7r35Il9VwfT X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239494 Archived-At: npostavs@gmail.com (Noam Postavsky) writes: Hi Noam, > --- a/test/src/process-tests.el > +++ b/test/src/process-tests.el > @@ -144,6 +144,35 @@ > (should (equal "hello stderr!\n" > (mapconcat #'identity (nreverse stderr-output) ""))))) > > +(ert-deftest set-process-filter-t () > + "Test setting process filter to t and back." ;; Bug#36591 > + (with-temp-buffer > + (let* ((print-level nil) > + (print-length nil) > + (proc (start-process > + "test proc" (current-buffer) > + (concat invocation-directory invocation-name) > + "-Q" "--batch" "--eval" > + (prin1-to-string > + '(let (s) > + (while (setq s (read-from-minibuffer "$ ")) > + (princ s) > + (princ "\n"))))))) > + (set-process-query-on-exit-flag proc nil) > + (send-string proc "one\n") > + (should > + (accept-process-output proc 1)) ; Read "one". > + (should (equal (buffer-string) "$ one\n$ ")) > + (set-process-filter proc t) ; Stop reading from proc. > + (send-string proc "two\n") > + (should-not > + (accept-process-output proc 1)) ; Can't read "two" yet. > + (should (equal (buffer-string) "$ one\n$ ")) > + (set-process-filter proc nil) ; Resume reading from proc. > + (should > + (accept-process-output proc 1)) ; Read "two" from proc. > + (should (equal (buffer-string) "$ one\n$ two\n$ "))))) This fails on emba occasionally, see for example . Best regards, Michael.