From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Newsgroups: gmane.emacs.devel Subject: Re: Reliable after-change-functions (via: Using incremental parsing in Emacs) Date: Mon, 30 Mar 2020 20:43:14 +0200 Message-ID: <87o8sdn0ot.fsf@gmail.com> References: <83o8sf3r7i.fsf@gnu.org> <2E218879-0F24-4A20-B210-263C8D0BEEA4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="95863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Yuan Fu , Andrea Corallo , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 30 20:43:27 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jIzNe-000OpP-9u for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Mar 2020 20:43:26 +0200 Original-Received: from localhost ([::1]:54942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIzNd-0004nb-Cp for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Mar 2020 14:43:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47459) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIzN6-0004OO-95 for emacs-devel@gnu.org; Mon, 30 Mar 2020 14:42:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIzN5-00017f-2j for emacs-devel@gnu.org; Mon, 30 Mar 2020 14:42:52 -0400 Original-Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]:33965) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIzN3-00013V-DA; Mon, 30 Mar 2020 14:42:49 -0400 Original-Received: by mail-lj1-x243.google.com with SMTP id p10so19025390ljn.1; Mon, 30 Mar 2020 11:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=6NUhOKB2rXL8shhxj9Bj33affVWCxf1NQlxmBpMw/Ag=; b=HjLzmFq/kTfsRgx5tUmj2uK/LSF2QudR3BO1HwlvFyZszMVBdDGPnMXbCWy3Tag4jG T6efw+VXcRh65D+7bzKEQgnSRtuhX+LQydKIg0H0sgsnH79uafMVQazPSZthsSup8o1O mCBhe8N2095hQRr/Wf0KJbq9TtJsANm3fIlIyr12qR2pIW65MXR2H3DqRL+unfBUf/KY 8zGPfiCcJv0kAm/JDXjRLrDPcJDnUzQAAGx+C8eCn2ppDCzD3k2n/2RY24t+jWXTtTEg 9fbd3ROyH0t1dw3bJPkUPfED4hZCCotiPg1pxJcc8LnfM3/AcejPzSWT1Cvo5CRa2JNM FixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=6NUhOKB2rXL8shhxj9Bj33affVWCxf1NQlxmBpMw/Ag=; b=OUlwikKIcyxL4pGkuNTC4Z+skddHTkS9sx5ZHF0DVug3rXbpYtzlSpO6LPv7qZ6JRm wvLWZDklZOI+by3HeD9MvlkDmAxFzqHk4NVchHloP0OfSXVZgCnexGlAGHp8E2ibKG75 Q2i6MlGnHZmS1pinZzCLWkYuq8K5WyKuA4/8E9cXIvt6LlAlc6CS7Bi7ItOGrL4kyj68 FyKA2SuRmkikePkgahzcEFemajkMDVDcfHil/+oZtqVRKR84bVZ4y33aMBEI8c/Q81j9 tsn1OowBtxg8XnBwLSGGShkX3AOGQ8bCL0mnl+JeWk8knjSxGb9ZetYhSxMDWJYfBt7k GJuw== X-Gm-Message-State: AGi0Pubm09Gn/iILjoTBTwBmlZUn1JBFhOhsowv1gM6VQzQjGAod0Bu/ OI8Ld6kkK5n1ptgL6Img3ag= X-Google-Smtp-Source: APiQypLyXZNnroaUxqXXB7xTsN0JDkrTIOSzb7WMQ31M78wMq5NU3NorfYSkzukdkZzQPSSaEYp9Jw== X-Received: by 2002:a2e:9588:: with SMTP id w8mr4503336ljh.262.1585593767707; Mon, 30 Mar 2020 11:42:47 -0700 (PDT) Original-Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id y23sm5768055ljh.42.2020.03.30.11.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 11:42:47 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 30 Mar 2020 13:54:53 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246054 Archived-At: On Mon, 30 Mar 2020 13:54:53 -0400 Stefan Monnier wrote: >>> If they needed to be informed of the change but >>> `inhibit-modification-hooks` prevented it, it's a bug. >>> Please report it. >> Do you mean it=E2=80=99s a bug in eglot/lsp-mode or it=E2=80=99s a bug in >> inhibit-modification-hooks (or the code who set it to t)? > > The fact that they're not informed is the bug. > So it's presumably not the fault of eglot/lsp-mode. > Whose fault it is will depend on the details of the particular situation > where it occurs. FWIW, I have described one such situation (unrelated to lsp) recently here: https://gitlab.com/stepnem/stripes-el/-/issues/1#note_309176403 (In short, `dired-readin' binds `inhibit-modification-hooks' to t, so the buffer changes caused by populating dired buffers are not noticeable in `after-change-functions'.) I was wondering if I should report it as a bug, despite the workaround not being particularly painful in this case (there's `dired-after-readin-ho= ok'). --=20 =C5=A0t=C4=9Bp=C3=A1n