From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: 31395511: =?utf-8?Q?=22Don=E2=80=99t?= attempt to modify constant strings" Date: Thu, 04 Jun 2020 00:20:51 +0100 Message-ID: <87o8pzivn0.fsf@tcd.ie> References: <871rmvn7ge.fsf@gmail.com> <1291ef4a-3a47-3990-9b5f-ec15bb72eb73@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="52691"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Paul Eggert , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 01:21:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgchR-000Dab-Q7 for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 01:21:33 +0200 Original-Received: from localhost ([::1]:41038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgchQ-0001H6-TW for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jun 2020 19:21:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgcgq-0000Ib-OB for emacs-devel@gnu.org; Wed, 03 Jun 2020 19:20:56 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:43777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgcgo-0001n0-JO for emacs-devel@gnu.org; Wed, 03 Jun 2020 19:20:56 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id l10so4087624wrr.10 for ; Wed, 03 Jun 2020 16:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7eRCrtKCaZzmYoiC9hvTM4L2HeIQl6J6mdREsjmBPYE=; b=qmmNb0wBuUetScRX0OKVycg8HB3i59QYKA/g81oi8YYmAdG6avi3ml7ltWYFozZse+ qsvutbexvNggxKkO0pDBtqFg3y7nHC54bO6zp4V0tZ7gH8rOKYwXeOaQf0dIn6DhSGOa 9rVTXyDv3WYhQQOhFy6Jmwaepbql2pVA5fPCUFZP65/hueB0nmZtaeALUbQchcrFM8Gj y0hlIvyLgcJBJbot+88spNgEVwpRcrNf+lp9PELQfWcTFOAIZ60XhNJHUqv0NwJG4gXQ ZwQXuSjSXPBVG8PqvArR6sLKxxzqNTPavEDqtyoC3N7hYMK8zfecR4tzUrLxrkYdC4eV zNMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7eRCrtKCaZzmYoiC9hvTM4L2HeIQl6J6mdREsjmBPYE=; b=iFwH7Jv1OzC9tjtuoY+b8ULx0vvDWXIeTeXF/FvdTLqhz1Sx8pjSn45/+hORdShK4Q sKCm8T1ZaDzzXVqY84mazMIpCIH6xgeYCjDOdPmfEEny0AAEa94VkiSmyeYZKvs2U6Co dLQ18SNJYEqXWSMC+ldXKXtVaSJ/DzYz9xhJ1B/ui1JwN3AF+06aprEl/9EI1bWwwdhg WMqNtk/hIPZks0ddCTsuXupPdzbZkszL/QbMaat5KRpNUrqf+tiC1rL4Y33+i86Y339q Zk55qTT++23jafS72P6Z94BIxAyHmLUlidRngSe24EannXfmCh7pHC2ZPRoPa17kRn45 NdfQ== X-Gm-Message-State: AOAM532sidAHPo/gpIBidolC5lE3wzgILceAMxbBoh+ZKbzBhVgB/yv4 S/mB6quwQxqkN7GPpfNoSNb6ow== X-Google-Smtp-Source: ABdhPJwXGceA407nyIzhx3rR5TlHAICZIOPXdIGJAE8NuEZ6YVeKdd/BJYWMxB1CDaChS1lD8M+EOw== X-Received: by 2002:adf:f84d:: with SMTP id d13mr1450979wrq.99.1591226452828; Wed, 03 Jun 2020 16:20:52 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id j18sm5514099wrn.59.2020.06.03.16.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 16:20:52 -0700 (PDT) In-Reply-To: (Pip Cet's message of "Wed, 3 Jun 2020 22:52:37 +0000") Received-SPF: none client-ip=2a00:1450:4864:20::429; envelope-from=contovob@tcd.ie; helo=mail-wr1-x429.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251836 Archived-At: Pip Cet writes: > On Wed, Jun 3, 2020 at 10:42 PM Paul Eggert wrote: >> On 6/3/20 2:52 PM, Jo=C3=A3o T=C3=A1vora wrote: >> > Not sure where the problem lies but every button inserted by SLY is now >> > just plain text. >> >> It's because I messed up in that part of the patch. Thanks for reporting= the >> bug. I installed the attached patch into master; please give it a try. > > I don't understand that change at all. All it does is replace a > six-argument setq by two successive setqs? Surely the symbol value is > irrelevant for the first, third, etc. argument to setq, so what > difference does it make? Indeed the patch seems like a noop and shouldn't fix Jo=C3=A3o's issue, whi= ch is that until now make-text-button modified its argument. --=20 Basil