From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Add new functions to mark/unmark/delete all bookmarks Date: Wed, 29 Jul 2020 17:16:09 -0500 Message-ID: <87o8nyvufq.fsf@red-bean.com> References: <20200724005105.11f85d5f@pineapple> <87pn8ku3y9.fsf@red-bean.com> <20200725124618.49a073b1@pineapple> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Matthew White Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 30 00:20:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0uRN-0004JR-5I for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Jul 2020 00:20:49 +0200 Original-Received: from localhost ([::1]:42990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0uRM-0005ew-7V for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jul 2020 18:20:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0uN3-0006wf-7M for emacs-devel@gnu.org; Wed, 29 Jul 2020 18:16:21 -0400 Original-Received: from newsp.red-bean.com ([45.79.25.59]:55838 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0uN0-0001Yr-Cs for emacs-devel@gnu.org; Wed, 29 Jul 2020 18:16:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=277etDU3DOtoHJ4QYcrsb+tIf3B3Puppk2BTF8up5j8=; t=1596060977; x=1597270577; b=D352irWsEcbzakzS8sScHv3w3OhCXRTSRyPNVr5BnSN0fbaGvkdM7Xx9T2JYRe9uLAHmj1UWS6 jYSOy7WGlrvDoOgXMGhUL3l5tajYJwRxrL09eiGImZuJ8HKuxoKYN0Q63FgDfS480+c2FJ5hiQinh GGH+kgKN+1pq5UsMZxunay681nHed8/nzTJgB4ehIh981y1b8n2l97qZ1jZQIHlLY2pTqvHQzs+7O AHgDO+aHUEcnhwznNbOfwmvNwqLgc3kFtw0x3Wsbo1iEcOwoOlEiqH6hZnQ9Phbi+ZWEMFMHvf7XM 8r8T8DXEAmEDzf9TyKtopBit3T8ChbfLbxLtg==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:60686 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0uMx-0004Ha-Bn; Wed, 29 Jul 2020 22:16:15 +0000 In-Reply-To: <20200725124618.49a073b1@pineapple> (Matthew White's message of "Sat, 25 Jul 2020 12:46:18 +0200") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 18:16:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253331 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Matthew. I had a chance to try out your latest patch for 'master'. No= te I only tried that one, since this change will go onto 'master' and not o= nto 'emacs-27'. When I tested manually, everything works fine: marking all, unmarking all, = deleting, everything's good. However, bookmark shows one test failure now = in 'make check': FAILED 2/47 bookmark-test-bmenu-any-marks-list (0.000279 sec) I haven't had time to investigate further yet, but I wanted to know if you'= re also seeing the same failure? I applied your patch using 'git am'. Bel= ow are HEAD and HEAD^ in my tree, so you can see exactly what code I'm test= ing with: > commit 23faf0e8d4daac5cc9c199efe97fa36c9d4691b6 > Author: Matthew White > AuthorDate: Thu Jul 23 21:14:32 2020 +0000 > Commit: Karl Fogel > CommitDate: Tue Jul 28 21:10:45 2020 -0500 >=20 > Add ability to mark/unmark/delete all bookmarks >=20=20=20=20=20 > * lisp/bookmark.el (bookmark-delete-all): New function to delete all > bookmarks. > (bookmark-bmenu-mark-all): New function to mark all bookmarks in = the > bookmark list buffer. > (bookmark-bmenu-unmark-all): New function to unmark all bookmarks= in > the bookmark list buffer. > (bookmark-bmenu-delete-all): New function to mark for deletion all > bookmarks in the bookmark list buffer. > (bookmark-map): Map "D" to `bookmark-delete-all'. > (bookmark-bmenu-mode-map): New mappping for "M" to > `bookmark-bmenu-mark-all'. > (bookmark-bmenu-mode-map): New mappping for "U" to > `bookmark-bmenu-unmark-all'. > (bookmark-bmenu-mode-map): New mappping for "D" to > `bookmark-bmenu-delete-all'. > (bookmark-bmenu-mark-all): New bookmark menu to > `bookmark-delete-all'. > (easy-menu-define): New bookmark menu to `bookmark-bmenu-mark-all= '. > (easy-menu-define): New bookmark menu to > `bookmark-bmenu-unmark-all'. > (easy-menu-define): New bookmark menu to > `bookmark-bmenu-delete-all'. > (bookmark-bmenu-select): Update docstring to include a reference = to > `bookmark-bmenu-mark-all'. > (bookmark-bmenu-mode): Update docstring. Add/Update description: > `bookmark-bmenu-mark-all', `bookmark-bmenu-delete-all', > `bookmark-bmenu-execute-deletions', and `bookmark-bmenu-unmark-al= l'. > * test/lisp/bookmark-resources/test-list.bmk: New bookmark file to > test a list of bookmarks. > * test/lisp/bookmark-tests.el (bookmark-tests-bookmark-file-list): = New > reference to the bookmark file used for testing a list of bookmar= ks. > (bookmark-tests-bookmark-list-0, bookmark-tests-bookmark-list-1, > bookmark-tests-bookmark-list-2): New cached values for testing a > list of bookmark. > (bookmark-tests-cache-timestamp-list): New variable to set > `bookmark-bookmarks-timestamp'. > (with-bookmark-test-list): New macro environment to test a list of > bookmarks. > (with-bookmark-test-file-list): New macro environment to test a l= ist > of bookmarks with example.txt. > (with-bookmark-bmenu-test-list): New macro environment to test > functions about a list of bookmarks from `bookmark-bmenu-list'. > (bookmark-tests-all-names-list, bookmark-tests-get-bookmark-list, > bookmark-tests-get-bookmark-record-list): New functions to test t= he > records of the list of bookmarks. > (bookmark-tests-make-record-list): New function to test the creat= ion > of a record from example.txt with a list of bookmarks loaded. > (bookmark-tests-delete-all): New function to test > `bookmark-delete-all'. > (bookmark-test-bmenu-any-marks-list): New function to test > `bookmark-bmenu-any-marks' with a list of bookmarks. > (bookmark-test-bmenu-mark-all): New function to test > `bookmark-bmenu-mark-all'. > (bookmark-test-bmenu-unmark-all): New function to test > `bookmark-bmenu-unmark-all'. > (bookmark-test-bmenu-delete-all): New function to test > `bookmark-bmenu-delete-all'. >=20 > M lisp/bookmark.el > A test/lisp/bookmark-resources/test-list.bmk > M test/lisp/bookmark-tests.el >=20 > commit eb9e065c00c5590967255fa3abf51db966a5df72 > Author: Juri Linkov > AuthorDate: Wed Jul 29 03:47:29 2020 +0300 > Commit: Juri Linkov > CommitDate: Wed Jul 29 03:47:29 2020 +0300 >=20 > * lisp/vc/vc-git.el (vc-git-log-view-mode): Font-lock AuthorDate (b= ug#40248) >=20=20=20=20=20 > Highlight "AuthorDate" in log-view-font-lock-keywords > when [format] pretty =3D fuller. >=20 > M lisp/vc/vc-git.el Attached is the full 'test/lisp/bookmark-tests.log' file after running 'mak= e check'. Best regards, =2DKarl --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=bookmark-tests.log Content-Transfer-Encoding: quoted-printable Content-Description: test/lisp/bookmark-tests.log (after 'make check' has completed) Running 47 tests (2020-07-29 17:06:19-0500, selector `(not (or (tag :expens= ive-test) (tag :unstable)))') passed 1/47 bookmark-test-bmenu-any-marks (0.000287 sec) Test bookmark-test-bmenu-any-marks-list backtrace: signal(ert-test-failed (((should (looking-at "^> ")) :form (looking- ert-fail(((should (looking-at "^> ")) :form (looking-at "^> ") :valu #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name bookmark-test-bmenu-any-marks-list :d ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...=20 ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/bookmark-tests" "--e command-line() normal-top-level() Test bookmark-test-bmenu-any-marks-list condition: (ert-test-failed ((should (looking-at "^> ")) :form (looking-at "^> ") :value nil)) FAILED 2/47 bookmark-test-bmenu-any-marks-list (0.000279 sec) passed 3/47 bookmark-test-bmenu-bookmark (0.000219 sec) Deleting bookmarks... \=20 Deleting bookmarks...done passed 4/47 bookmark-test-bmenu-delete (0.000237 sec) Deleting bookmarks... \=20 Deleting bookmarks...done Deleting bookmarks... \=20 Deleting bookmarks...done passed 5/47 bookmark-test-bmenu-delete-all (0.000508 sec) passed 6/47 bookmark-test-bmenu-edit-annotation/show-annotation (0.00= 0286 sec) passed 7/47 bookmark-test-bmenu-filter-alist-by-regexp (0.000197 sec) passed 8/47 bookmark-test-bmenu-hide-filenames (0.000171 sec) passed 9/47 bookmark-test-bmenu-locate (0.000181 sec) passed 10/47 bookmark-test-bmenu-mark (0.000159 sec) passed 11/47 bookmark-test-bmenu-mark-all (0.000237 sec) Annotation updated for "name" passed 12/47 bookmark-test-bmenu-send-edited-annotation (0.000480 sec) Annotation updated for "name" passed 13/47 bookmark-test-bmenu-send-edited-annotation/restore-focus = (0.000472 sec) passed 14/47 bookmark-test-bmenu-show-filenames (0.000161 sec) passed 15/47 bookmark-test-bmenu-toggle-filenames (0.000174 sec) passed 16/47 bookmark-test-bmenu-toggle-filenames/show (0.000155 sec) passed 17/47 bookmark-test-bmenu-unmark (0.000171 sec) passed 18/47 bookmark-test-bmenu-unmark-all (0.000254 sec) passed 19/47 bookmark-tests-all-names (0.000065 sec) passed 20/47 bookmark-tests-all-names-list (0.000062 sec) passed 21/47 bookmark-tests-default-annotation-text (0.000058 sec) passed 22/47 bookmark-tests-delete (0.000063 sec) passed 23/47 bookmark-tests-delete-all (0.000060 sec) Annotation updated for "name" passed 24/47 bookmark-tests-edit-annotation (0.000198 sec) passed 25/47 bookmark-tests-get-bookmark (0.000051 sec) passed 26/47 bookmark-tests-get-bookmark-list (0.000052 sec) passed 27/47 bookmark-tests-get-bookmark-record (0.000047 sec) passed 28/47 bookmark-tests-get-bookmark-record-list (0.000049 sec) Mark set passed 29/47 bookmark-tests-insert (0.054729 sec) passed 30/47 bookmark-tests-insert-annotation (0.000110 sec) passed 31/47 bookmark-tests-insert-location (0.000063 sec) passed 32/47 bookmark-tests-jump (0.037029 sec) passed 33/47 bookmark-tests-kill-line (0.000073 sec) passed 34/47 bookmark-tests-load (0.108157 sec) passed 35/47 bookmark-tests-location (0.000074 sec) passed 36/47 bookmark-tests-make-record (0.033908 sec) passed 37/47 bookmark-tests-make-record-function (0.008674 sec) passed 38/47 bookmark-tests-make-record-list (0.036535 sec) passed 39/47 bookmark-tests-maybe-historicize-string (0.000048 sec) passed 40/47 bookmark-tests-maybe-rename (0.000046 sec) passed 41/47 bookmark-tests-record-getters-and-setters-new (0.000076 s= ec) passed 42/47 bookmark-tests-rename (0.000080 sec) Saving bookmarks to file /tmp/bookmark-tests-nWOh5y... \=20 Saving bookmarks to file /tmp/bookmark-tests-nWOh5y...done passed 43/47 bookmark-tests-save (0.001546 sec) Saving bookmarks to file /tmp/bookmark-tests-ta0qZH... \=20 Saving bookmarks to file /tmp/bookmark-tests-ta0qZH...done passed 44/47 bookmark-tests-save/non-ascii-annotation (0.044920 sec) Saving bookmarks to file /tmp/bookmark-tests-Y7mZuJ... \=20 Saving bookmarks to file /tmp/bookmark-tests-Y7mZuJ...done passed 45/47 bookmark-tests-save/non-ascii-bookmark-name (0.001665 sec) passed 46/47 bookmark-tests-set (0.036700 sec) Annotation updated for "foo" passed 47/47 bookmark-tests-set/bookmark-use-annotations-t (0.036375 s= ec) Ran 47 tests, 46 results as expected, 1 unexpected (2020-07-29 17:06:20-050= 0, 0.482341 sec) 1 unexpected results: FAILED bookmark-test-bmenu-any-marks-list --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEsgfAWXyjn8Fyi3xbCKC3XMXtg0UFAl8h9SkUHGtmb2dlbEBy ZWQtYmVhbi5jb20ACgkQCKC3XMXtg0V+7w//UiSX13MBY61E3rYOh1skfok8bSdM X5UgLCmzsYekH801dOl01OscYWbXBYXbS2uRIn7wSVt3qHI6Qqojqnc69SR6xXJY brUCdKOkVCzriRq17+7G8bwXCmMvhCHzolGfsyo6rS/F32OYAOZqJ/U2Qn1WThjC vPubUku+P2ajxdWhwbdiENO90YQSH8p+/ZHpKWg5B525x5dywqBhLOJNdjGEkI3k pr13XnyRK3M8OGXgvteRaCTLF6hwUYPIFDOSWJi6N7AQo5E9huGrKZNRL0nJAzln 9GCb2xpmevLZJAxC5aGTuXifBgsw91oHNCdu2RtMezUWydWSATYORFM7ExXoTs8X VSnp7zli2aE1td7VPECDKRGcGP+UYpbvH5rvdqZ9OUq3cu5+wuu2pff2XbwXk/Ay H+ZxwBCugQoWmviSrYYCFZeUYzAooj5ZFYfCGZW7pZJAFYKimWGiD4MhAOA0Xuf/ gh5J4A6/UZABH+tr3jdCGR2Rm5MBYM/EFpJmlHRZgKLhkww3w99W9IUHbHVXLOWA OPDw2o7ZWzXwOri2gxrtZSjV7Ua0luBS2abKc661kLTWyOf21+M7LQKhSi79irFM 4OYK3UjlLfuYFV5XaM5pSZkHyiS3e3K0uJ4oF6lwqBlJ9geKnB89U26GQe8ixPzi Cgx4o5CkgxqTnaU= =SzJi -----END PGP SIGNATURE----- --==-=-=--