From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Two fixes for module bug when interleaving threads Date: Sun, 29 Nov 2020 21:44:19 +0200 Organization: LINKOV.NET Message-ID: <87o8jgvtxg.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2862"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 29 20:52:35 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjSkM-0000aZ-EO for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Nov 2020 20:52:34 +0100 Original-Received: from localhost ([::1]:46630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjSkL-0007te-7S for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Nov 2020 14:52:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjShk-000580-EK for emacs-devel@gnu.org; Sun, 29 Nov 2020 14:49:52 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjShi-0000rY-Th for emacs-devel@gnu.org; Sun, 29 Nov 2020 14:49:52 -0500 X-Originating-IP: 91.129.99.98 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 075D5E0002; Sun, 29 Nov 2020 19:49:47 +0000 (UTC) In-Reply-To: (Philipp Stephani's message of "Fri, 27 Nov 2020 21:57:41 +0100") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260032 Archived-At: > I just pushed two fixes for the same bug that appears when > interleaving module calls in separate threads: > cdc632fbe6e149318147a98cccf1b7af191f2ce8 for the release branch and > 23974cfa48b9245658667eff81d132b3aecd2618 for master. The intention was > that a simpler and more localized fix should go to the release branch, > the "proper" fix to master. Now I've realized that arguably the > simpler fix is overall better: it's more localized, touches fewer > moving pieces, and is probably not significantly slower (though I > haven't benchmarked it). Any opinions? If people agree, we can > overwrite the fix on master with the fix on the release branch. Unfortunately, 23974cfa48b9245658667eff81d132b3aecd2618 in master broke module loading: while loading a module, Emacs prints the message "Loading (module)..." and hangs, doesn't react to input, becomes completely unresponsive to C-g. Here's is the shortest reproducible test case: M-x package-install RET zmq RET (load-file "~/.emacs.d/elpa/zmq-20200912.1126/emacs-zmq.so") It hangs after printing to stderr: double free or corruption (!prev) Fatal error 6: Aborted Fortunately, this problem doesn't exist in the 27 release branch.