From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.emacs.devel Subject: Re: [patch] system_process_attributes for OpenBSD Date: Sat, 02 Jan 2021 11:36:22 +0100 Message-ID: <87o8i7pqvt.fsf@omarpolo.com> References: <87k0sw5lzt.fsf@omarpolo.com> <878s9bpzj8.fsf@asteroid.bittivirhe.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40148"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.13; emacs 27.1 Cc: emacs-devel@gnu.org To: Timo =?utf-8?Q?Myyr=C3=A4?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 02 11:37:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kveI0-000ADs-B9 for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jan 2021 11:37:40 +0100 Original-Received: from localhost ([::1]:59208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kveHz-00013i-CO for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Jan 2021 05:37:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kveGz-0000bJ-Pc for emacs-devel@gnu.org; Sat, 02 Jan 2021 05:36:37 -0500 Original-Received: from mail.omarpolo.com ([144.91.116.244]:51749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kveGw-00060S-Mm for emacs-devel@gnu.org; Sat, 02 Jan 2021 05:36:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1609583784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KsID+W7NvJuXurQ47Nq+baVoK+mFbfGKsfWm7HCjNRg=; b=yz6bN/aiO8mWsXGXg5ftZeqJsr0WznWxGKUExhelgZ5r40QCyIQmIrnKi6IKblf7rf7gt6 D3IdocFcViC9aV+YzLHTNUteWBzgtC5ljUqd4aCyhbvzdABm7J3xB/GiizfwmdxS98dS2A JsV/NT+Gx/s3qYFt80y/f/nUEYWIb/U= Original-Received: from localhost (host-80-116-112-105.retail.telecomitalia.it [80.116.112.105]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 5e097015 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 2 Jan 2021 11:36:24 +0100 (CET) Original-Received: from venera (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 84500b50; Sat, 2 Jan 2021 11:36:22 +0100 (CET) In-reply-to: <878s9bpzj8.fsf@asteroid.bittivirhe.fi> Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262308 Archived-At: Timo Myyr=C3=A4 writes: > Omar Polo [2021-01-01, 23:29 +0100]: > >[snip] > > Hi Omar, > > Are you sure you need kvm? I'm under impression its frowned upon to > access that from userland. Thanks for sharing! I haven't followed closely the development of OpenBSD, but at least on -CURRENT trying to get a struct kinfo_proc for a specific pid via sysctl results in errors (both from sysctl(8) and sysctl(3)): $ sysctl kern.proc sysctl: use ps to view kern.proc information $ sysctl kern.proc 75056 # a valid pid sysctl: use ps to view kern.proc information sysctl: top level name 75056 in 75056 is invalid $ cat < pid.c #include #include #include #include int main(void) { pid_t pid =3D 75056; /* valid pid */ int mib[4] =3D { CTL_KERN, KERN_PROC, KERN_PROC_PID, pid }; struct kinfo_proc proc; size_t len =3D sizeof(proc); if (sysctl(mib, 4, &proc, &len, NULL, 0) !=3D 0 || len =3D=3D 0) err(1, "sysctl"); return 0; } EOF $ cc pid.c -o pid && ./pid pid: sysctl: Invalid argument $ ps 75056 75056 ?? S 0:38.85 emacs --daemon (emacs-27.1) This plus the fact that both top and ps in base uses kvm were the rationale for my choice. Regarding list_system_processes, I still have to check the differences, but the current version on master is fundamentally equivalent to yours (modulo a bunch of #ifdefs for freebsd and macos), so I guess it was merged at some point? Here on emacs-27.1 (list-system-processes) returns nil, but on emacs compiled from master it works correctly.