From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 8f28a1b: Tweak `condition-case' keyword highlights Date: Sun, 24 Jan 2021 22:45:25 +0100 Message-ID: <87o8heovpm.fsf@gnus.org> References: <20210124203118.16450.28084@vcs0.savannah.gnu.org> <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36131"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 24 22:46:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3nDa-0009IK-1z for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jan 2021 22:46:46 +0100 Original-Received: from localhost ([::1]:38554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3nDY-0002kv-Up for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jan 2021 16:46:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3nCS-0001xH-AQ for emacs-devel@gnu.org; Sun, 24 Jan 2021 16:45:37 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:56274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3nCQ-0005qa-K4 for emacs-devel@gnu.org; Sun, 24 Jan 2021 16:45:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/xHOgYuhESO48z56n03lmjlZrxdf4YDqUB7vB2RyGWs=; b=uXjR8JsUSzDZgxGIfEbvYiBT/V EKQpti1WKa5QKAPIE/MhTBkimFxI0YO2MzPBNGITAtfuCeOOeiFvQMvYAoLCGkEVR6I1YpHSkpyjF runbEH6c7Tbbb1EF9YMpGN0wx4R9O8b6L8EN3Mq2QFe5f+Uv+U74OMod+dN2h/JgMepc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3nCJ-0004CA-Mb; Sun, 24 Jan 2021 22:45:30 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX29PKpoJ5ANjyE eXv////bjemzAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UBGBUoIrBA+IQAAAGiSURBVDjLnZQJbsQg DEVZLoDhAsG+AMv979ZvA0mmlSq1HmWkzMMxvNjj3D8il9nLZJY55+AVBqZ+eZaeSsqjE1FZoOBK ClwGSHZzgK8LVAPtAZEV+LEA+7tGMBC5Zk6OOJ0MzwbyAuWAiQQBwI7rwKOY6YAhF5Jwhj4YW+K4 QA9cFbBmMA2RDch3qs6ADOQJ7wOSa647kyEqhsYLuAWwvk8qG2RdOrc9FiGaD1gxbWufdnFqct7l byAmAwGgQ9Z9QNgFSC40AOfbIzGyAtgNAE5u4PMCvMDjKrIB2A3cUaG/7GrxwZfWGA/ALwCFOQ1w Pq7wguQK6km1w6Pk7arAbjRTss6XX9oJS/FZiscBzXnSR03LmEcJbtCct0krdsCPWABaKfO1X4Fo ax8QuoHitK8Q+4DJxWogpgDwths4KMiXAqy/7Q4Dql0znhaNLAoiG/joXauBKzBh++llVwHsAljr LwC7yGiZh4LMp3dn6QWSWi65BWus/T4mVQUJPdSiNeUBpRLmHEDnVYd9fkjsxSZ8Cv4Nxu928xmN NQcP+GN8AWUfXI8JbkajAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTI0VDIxOjQwOjM0KzAw OjAwOroTcAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0yNFQyMTo0MDozNCswMDowMEvnq8wA AAAASUVORK5CYII= X-Now-Playing: The Style Council's _The Complete Adventures (2)_: "Walls Come Tumbling Down" In-Reply-To: (Stefan Monnier's message of "Sun, 24 Jan 2021 16:32:56 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263358 Archived-At: Stefan Monnier writes: >> +(ert-deftest test-elisp-font-keywords-5 () >> + (should (eq (test--font '(condition-case (when a) >> + (foo) >> + (error t)) >> + "(\\(when\\)") >> + nil))) > > FWIW, I'd be just as happy if `when` were highlighted with a keyword > face in this case: it's invalid code anyway, so the only highlighting > that would actually be helpful is one with some kind of error/warning > face, but I think it's best to leave it to `flymake-mode` to do that for us. Sure, I just wanted to tighten the check in that function to the actual form it was checking, instead of including the VAR form, too. Nobody would actually write something like that. But speaking of other code that's mis-highlighted still: (defun a (when b c) ...) (The `when' isn't a keyword here, but it's font-locked as such.) Couldn't we just use `edebug-form-spec' to notice that the arglist isn't a funcall position? That would get a huge number of macros/special forms with non-funcall positions right... `lisp--el-non-funcall-position-p' would have to parse that, though, which might slow things down? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no