From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Sorting command completions by recency Date: Wed, 17 Feb 2021 22:09:33 +0200 Organization: LINKOV.NET Message-ID: <87o8gifoci.fsf@mail.linkov.net> References: <875z2qslwk.fsf@mail.linkov.net> <877dn635oe.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 17 21:16:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCTFB-0009EC-T3 for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 21:16:17 +0100 Original-Received: from localhost ([::1]:38784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCTFA-0003Oz-RT for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 15:16:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTDE-0001yu-Sk for emacs-devel@gnu.org; Wed, 17 Feb 2021 15:14:20 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:57145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCTD8-0004yt-Qr for emacs-devel@gnu.org; Wed, 17 Feb 2021 15:14:16 -0500 X-Originating-IP: 91.129.96.116 Original-Received: from mail.gandi.net (m91-129-96-116.cust.tele2.ee [91.129.96.116]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6D46C1BF20B; Wed, 17 Feb 2021 20:14:06 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 17 Feb 2021 14:55:46 -0500") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265078 Archived-At: >>> This code puts the recent commands at the top as well, >>> but probably it needs to be opt-in: >> Makes sense to me, and, yes. > > FWIW, the minibuffer.el code already uses this kind of sorting for the > list of completions used in things like `icomplete` and > `completion-cycle-threshold`. I stole code from `completion-all-sorted-completions' used by `icomplete`, but see no way to call it directly. > For *Completions* the sort was kept alphabetical so far because that's > also useful (for example in the case of M-x completion, it makes it > easier to skip over blocs of commands sharing the same prefix). > > So, while I think it can be useful to sort by some kind of "guessed > usefulness" such as presence in the history, I don't think this should > be forced by the completion table of commands. Maybe a new option should allow switching the sorting order. Perhaps, it should have a form of an alist: '(("alphabetical" . identity) ("by recency" . (lambda (commands) (if (minibufferp) ;; Prefer recently used completions and put the default, ;; if it exists, on top. (let ((hist (symbol-value minibuffer-history-variable))) (sort commands ...