From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Sat, 01 May 2021 22:54:28 +0300 Organization: LINKOV.NET Message-ID: <87o8dus00b.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , Dmitry Gutov , Stefan Monnier , "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 01 22:34:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcwJw-0008Qm-Rk for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 22:34:36 +0200 Original-Received: from localhost ([::1]:40292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcwJv-0006wS-VB for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 16:34:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcwIx-0005ss-QA for emacs-devel@gnu.org; Sat, 01 May 2021 16:33:35 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:42653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcwIv-0001jo-GB for emacs-devel@gnu.org; Sat, 01 May 2021 16:33:35 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id BC613240003; Sat, 1 May 2021 20:33:26 +0000 (UTC) In-Reply-To: <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> (Daniel Mendler's message of "Fri, 30 Apr 2021 20:13:00 +0200") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268733 Archived-At: >> Aren't affixations guarded by completions-detailed >> and grouping guarded by completions-group orthogonal? >> Then it should be fine to have separate options. > > Yes, they are orthogonal. I agree we can keep it as is. I still wanted > to point it out. And note the difference - the completions-group guard > variable is checked in minibuffer.el, while the completions-detailed > variable is checked in the completion table in help-fns.el. Maybe > completions-detailed should also be checked in the minibuffer.el instead? I think both completions-detailed and completions-group should be checked only by the API user like in help-fns.el. Otherwise, there is duplication that you can see in my previous patch for read-char-by-name: (let* ((enable-recursive-minibuffers t) (completion-ignore-case t) (completion-tab-width 4) (completions-group read-char-by-name-group) ======================= (input (completing-read prompt (lambda (string pred action) (if (eq action 'metadata) `(metadata (group-function . ,(when read-char-by-name-group ======================= #'mule--ucs-names-group)) The same user option read-char-by-name-group is checked twice. It should suffice to leave only the latter.