From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Semyonov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Two patches for mairix.el Date: Sat, 01 May 2021 18:19:56 +0300 Message-ID: <87o8dulbvn.fsf@dsemy.com> References: <83wnsi8ql2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33574"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 01 17:21:01 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcrQT-0008eC-5K for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 17:21:01 +0200 Original-Received: from localhost ([::1]:49584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcrQS-0003qc-7F for ged-emacs-devel@m.gmane-mx.org; Sat, 01 May 2021 11:21:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcrPf-00034P-2h for emacs-devel@gnu.org; Sat, 01 May 2021 11:20:11 -0400 Original-Received: from mout-p-102.mailbox.org ([2001:67c:2050::465:102]:31326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1lcrPa-0004MK-0M; Sat, 01 May 2021 11:20:10 -0400 Original-Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4FXXwd0W57zQjbb; Sat, 1 May 2021 17:20:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dsemy.com; s=MBO0001; t=1619882399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=jSd4MnTCkUdxxWYdEIwgmXs86osyWpOxIOEtLVc/7wc=; b=tNHCuwTPXgrbTA7tdDVXpqjLBB42VCBaEQBaaIOoyjxmLPfUqxOWNJuMbPYXOziqs+uoJK CzTw9tst6Nnm151WjmJyPOgFdQsZ3GwHo01d2DE12/shPymf9ZIG41iDPKylQaIvDfnfRk 7Oshs+4fRI6wGiA2eZOllIVZr9/o4zQWcv+Vt16WAZC6rPh49gnNFpOJSuayoJ4evkkpd/ P4uwuldXp3zWgNePiTlgz5yAXj8hPSFlrZO768yXkTSKTYnC04qYy3HzhhucjqzwD1bEEV IDasEI5Zoob5K9SsKfRFponcCHiH0krGKJoFYL8v1W/4ny5RUn3KOARmYtA3MA== Original-Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id PXK1H_QT7o6L; Sat, 1 May 2021 17:19:58 +0200 (CEST) In-Reply-To: <83wnsi8ql2.fsf@gnu.org> (message from Eli Zaretskii on Sat, 01 May 2021 17:40:41 +0300) X-Rspamd-Score: -4.97 / 15.00 / 15.00 X-Rspamd-Queue-Id: 1410D1800 X-Rspamd-UID: 3bec47 Received-SPF: pass client-ip=2001:67c:2050::465:102; envelope-from=cmstr@dsemy.com; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268717 Archived-At: --=-=-= Content-Type: text/plain > The changes are indeed small enough for us to accept them, but could > you please reformat the log message(s) according to our conventions? Of course, I've attached the fixed patches. > You will find the conventions described in CONTRIBUTE, and I suggest > to use "git log" to look at the log messages as examples. > > Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Mairix-autoload-main-interactive-functions.patch Content-Description: first patch >From bc65d635c45241f0e5942b8318ca62ed07662408 Mon Sep 17 00:00:00 2001 From: Daniel Semyonov Date: Sat, 1 May 2021 17:01:22 +0300 Subject: [PATCH] Mairix: autoload main interactive functions * lisp/net/mairix.el (mairix-search, mairix-use-saved-search) (mairix-edit-saved-searches-customize, mairix-search-from-this-article) (mairix-search-thread-this-article, mairix-widget-search-based-on-article) (mairix-edit-saved-searches, mairix-widget-search, mairix-update-database): Add magic autoload comment. Copyright-paperwork-exempt: yes --- lisp/net/mairix.el | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lisp/net/mairix.el b/lisp/net/mairix.el index 024d118f2d..adc41b6068 100644 --- a/lisp/net/mairix.el +++ b/lisp/net/mairix.el @@ -328,6 +328,7 @@ mairix-vm-fetch-field ;;;; Main interactive functions +;;;###autoload (defun mairix-search (search threads) "Call Mairix with SEARCH. If THREADS is non-nil, also display whole threads of found @@ -342,6 +343,7 @@ mairix-search threads) (mairix-show-folder mairix-search-file))) +;;;###autoload (defun mairix-use-saved-search () "Use a saved search for querying Mairix." (interactive) @@ -374,6 +376,7 @@ mairix-save-search (setcdr (assoc name mairix-saved-searches) mairix-last-search)))) (mairix-select-save)) +;;;###autoload (defun mairix-edit-saved-searches-customize () "Edit the list of saved searches in a customization buffer." (interactive) @@ -386,6 +389,8 @@ mairix-edit-saved-searches-customize (make-string 65 ?=) "\n"))) (autoload 'mail-strip-quoted-names "mail-utils") + +;;;###autoload (defun mairix-search-from-this-article (threads) "Search messages from sender of the current article. This is effectively a shortcut for calling `mairix-search' with @@ -402,6 +407,7 @@ mairix-search-from-this-article threads) (error "No function for obtaining mail header specified")))) +;;;###autoload (defun mairix-search-thread-this-article () "Search thread for the current article. This is effectively a shortcut for calling `mairix-search' @@ -423,12 +429,14 @@ mairix-search-thread-this-article (mairix-search (format "m:%s" mid) t))) +;;;###autoload (defun mairix-widget-search-based-on-article () "Create mairix query based on current article using widgets." (interactive) (mairix-widget-search (mairix-widget-get-values))) +;;;###autoload (defun mairix-edit-saved-searches () "Edit current mairix searches." (interactive) @@ -441,6 +449,7 @@ mairix-edit-saved-searches (defvar mairix-widgets) +;;;###autoload (defun mairix-widget-search (&optional mvalues) "Create mairix query interactively using graphical widgets. MVALUES may contain values from current article." @@ -470,6 +479,7 @@ mairix-widget-search (widget-setup) (goto-char (point-min))) +;;;###autoload (defun mairix-update-database () "Call mairix for updating the database for SERVERS. Mairix will be called asynchronously unless -- 2.31.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Mairix-use-mairix-search-options-as-documented.patch Content-Description: second patch >From 22246945b5a3b144be0ee14c9c07bedaa63df179 Mon Sep 17 00:00:00 2001 From: Daniel Semyonov Date: Sat, 1 May 2021 17:03:07 +0300 Subject: [PATCH] Mairix: use 'mairix-search-options' as documented * lisp/net/mairix.el (mairix-call-mairix): Append 'mairix-search-options' to the arguments passed to mairix. Copyright-paperwork-exempt: yes --- lisp/net/mairix.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/net/mairix.el b/lisp/net/mairix.el index adc41b6068..e1d35c2a85 100644 --- a/lisp/net/mairix.el +++ b/lisp/net/mairix.el @@ -531,8 +531,11 @@ mairix-call-mairix If FILE is nil, use default. If THREADS is non-nil, also return whole threads. Function returns t if messages were found." (let* ((commandsplit (split-string mairix-command)) - (args (cons (car commandsplit) - `(nil ,(get-buffer-create mairix-output-buffer) nil))) + (args (cons + (car commandsplit) + (append + `(nil ,(get-buffer-create mairix-output-buffer) nil) + mairix-search-options))) rval) (with-current-buffer mairix-output-buffer (erase-buffer)) -- 2.31.1 --=-=-=--