From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [WIP PATCH] Controlling Isearch from the minibuffer Date: Sun, 09 May 2021 22:05:08 +0300 Organization: LINKOV.NET Message-ID: <87o8djohqf.fsf@mail.linkov.net> References: <87zgx5cz33.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17467"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 09 21:18:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfowj-0004Op-DM for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 21:18:33 +0200 Original-Received: from localhost ([::1]:38520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfowi-0002ux-8W for ged-emacs-devel@m.gmane-mx.org; Sun, 09 May 2021 15:18:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfov9-0000o3-Pc for emacs-devel@gnu.org; Sun, 09 May 2021 15:16:55 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfov7-0001ZU-7K for emacs-devel@gnu.org; Sun, 09 May 2021 15:16:55 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 7D058FF805; Sun, 9 May 2021 19:16:45 +0000 (UTC) In-Reply-To: <87zgx5cz33.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 08 May 2021 12:13:52 +0200") Received-SPF: pass client-ip=217.70.183.199; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269096 Archived-At: > - Does the approach taken here seem sufficiently robust? Note in > particular the `with-isearch-window' macro, which is now needed around > several functions, You can avoid the with-isearch-window macro by checking in isearch-pre-command-hook if the current buffer is the minibuffer, then switch to the original buffer, and let the isearch command to do what it normally does, then switch back to the minibuffer in isearch-post-command-hook. > as well as the somewhat hacky `run-with-idle-timer' > call inside the `isearch-mode' function. You can avoid the timer hack by adding a guard to isearch-post-command-hook: when at the end of the isearch command, point is not in the minibuffer, activate the minibuffer (assuming that isearch-from-minibuffer is t). > - Are the slightly backwards incompatible keybinding changes in > `isearch-edit-string' acceptable? Only when isearch-from-minibuffer is t. > - I don't like the `with-isearch-window-quitting-edit' macro, but I > don't see a different way of achieving the necessary effect. The with-isearch-window-quitting-edit macro can be avoided the same way as the with-isearch-window macro.