From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 4a1e97b: New user option for Git log switches Date: Thu, 10 Jun 2021 09:34:30 +0200 Message-ID: <87o8ceuq9l.fsf@gmx.de> References: <20210608233619.8439.15341@vcs0.savannah.gnu.org> <20210608233620.E895F209C6@vcs0.savannah.gnu.org> <875yyn2st3.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37975"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Utkarsh Singh , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 10 09:35:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrFDm-0009ha-8n for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 09:35:22 +0200 Original-Received: from localhost ([::1]:53892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrFDl-0003aI-8K for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 03:35:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrFDD-0002tI-1N for emacs-devel@gnu.org; Thu, 10 Jun 2021 03:34:47 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:57079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrFD0-00067E-Qf for emacs-devel@gnu.org; Thu, 10 Jun 2021 03:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623310472; bh=JrKdPENJzx7v6Phfue758WppcD2MPZT2oWm30HiTAFE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=L3Shagp1nMn5BtYxZKHBjkhYzVwB9Kcw0z6gzQ2JmVEsA7hpN5LZZiruyHJYivfFB qWHzr0WpYG61LEaB+dm+UaYVNfmiW49MVsoCSsDNf5c11j3kUltuh6hG4X0l0VOYUX R30Oj9WtutX+zgNVNE6hT12bjHqq6Vn4ybcYhngI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.119.150]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M2f5T-1lupqJ1GO7-0047ny; Thu, 10 Jun 2021 09:34:32 +0200 In-Reply-To: (Dmitry Gutov's message of "Wed, 9 Jun 2021 19:01:44 +0300") X-Provags-ID: V03:K1:90m8yEPtzKigaVUgpr7AWLaMI7ekuDnOSEOwmdbuY2Iq625tNC+ X0ddEPPKThRRIfQQ3cssXgOJ98rIP2hdZA+jZq2C4rn8wQGZ9gdH6QRj3Cg7NQe/oX1SXLE mpYjXqvAzSsGFXUth7og/KXX2Eq8+3z5QfGj5WWtARxSHaeNf15q8Vvp4AVooxCcUJhiPaB x2DcgDp0f72luDSnpaHTA== X-UI-Out-Filterresults: notjunk:1;V03:K0:QYzM1Runtmc=:TnVMXuvDyEm2QcHGSeIqXz g3Nm8Ya3/fH9U1DS50yy4AKW1VkAUVziSxjORPGYqYEQfB9oGSzZh2DJL/8KteM6o5hqvWwBF y1+Rnvc0b+vRQ7E0UX0Cx05rr31e0NOcZGZamYaTmSv4i0CV8B5/yotNCHfvOEXnLMpvneQos MsivO2zb8RznsKvhVG376USKADZ6rPwGJ8CC8cEuhR93tFhOxLZLjJqPN1xIYwn1Hrl1z7crA T0SqxfED6tTEebpoMbr8/gvyv8IDmjd81TzGhYYUwFH+2QjfFntPctneQR9hFIZIZ81KTGlQF yErbMkG1ytzC3Ww7JoNAGpIYl+jNyvkIiKefy7wf7ZkFNx5BF4exc/dpHvax/VYrHgs3fAHDJ Tfq5u8TGWz9Ji9B63JlL9gUgvpokN8lbtlBE+m4Fmw9QuAxftP0p05ZXkKo/3nNxk18UZ/Fy4 sbWCmyeCp5lGrTMHCNT6XXphzslmjdMtMDKmoLCEVkLWnJHZF1501YfXv+8M9nP6Ta+QnYpVB wad2mCHncIiQacXQ5TWTdGUFL/jOr/ZaTb6c0ayZjv9dWWIO9bi1/bMtOgUiUEHSa1hDWkugH SLuug5nqP96hJ0CbK1AGbdiZRFgeyPgPgn8jXE0KJTm4Hd0TzwS7dS6YpXgq0Yb8Jmog5VT0w wcbvE/1zKbnGq9B5ksqIN0RAXAnzktxer/XoOxjJMOe+hVG71aY9Gfc/nonfh13VDZ2d6pcIy Eq7ti+J/LBexQ7v0trp7ab64QIlW9SXTPYOM8vgocNBwG1y2/xdiYIVTT8unx8q1Yv9Lc3/T Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270635 Archived-At: Dmitry Gutov writes: > Hi Michael, Hi Dmitry, >>> +(defcustom vc-git-log-switches t >>> + "String or list of strings specifying switches for Git log under VC." >>> + :type '(choice (const :tag "None" t) >>> + (string :tag "Argument String") >>> + (repeat :tag "Argument List" :value ("") string)) >>> + :version "28.1") >> Is there a reason to use the t value for "None"? All other log >> switches >> (vc-bzr-log-switches, vc-hg-log-switches, vc-src-log-switches) use nil >> for this purpose, and it sounds also more natural to me as being an >> empty list of strings. > > nil also works. > > The author followed the example of 'diff switches', where there is a > certain hierarchy of variables to follow if the backend-specific one > returns nil. Existing vc-*-diff-switches declare :type '(choice (const :tag "Unspecified" nil) (const :tag "None" t) (string :tag "Argument String") (repeat :tag "Argument List" :value ("") string))) Existing vc-*-log-switches declare :type '(choice (const :tag "None" nil) (string :tag "Argument String") (repeat :tag "Argument List" :value ("") string))) > I figured it wouldn't be too bad to allow that possibility in the > future, but you are probably right and we should simplify this. In favor of uniformity, vc-git-log-switches might follow the scheme. > 'hg log' and 'git log' are pretty different after all. Sure. But we're speaking about defcustom types, aren't we? Best regards, Michael.