From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add option COUNT argument to text-property-search functions Date: Sat, 31 Jul 2021 13:36:59 +0200 Message-ID: <87o8aiiujo.fsf@gnus.org> References: <87im0rlias.fsf@gmail.com> <87fsvvk2bw.fsf@gnus.org> <87fsvvlgop.fsf@gmail.com> <94e8df7f-3293-87c1-2172-d979cefda28a@yandex.ru> <87mtq30y5w.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25399"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "James N. V. Cash" , emacs-devel@gnu.org, Dmitry Gutov To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 31 13:38:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9nJs-0006TP-HS for ged-emacs-devel@m.gmane-mx.org; Sat, 31 Jul 2021 13:38:20 +0200 Original-Received: from localhost ([::1]:47266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9nJr-0002Uk-JV for ged-emacs-devel@m.gmane-mx.org; Sat, 31 Jul 2021 07:38:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9nIi-0001jj-AJ for emacs-devel@gnu.org; Sat, 31 Jul 2021 07:37:08 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9nIg-0006s9-Ph for emacs-devel@gnu.org; Sat, 31 Jul 2021 07:37:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=61QxdVQLHutWFfrWBgU8cEXEzsAamsXbFtoC8dEhwaQ=; b=bTLV9dhGbMJGfAD73Q1cC0psp+ dpgY6F1py4qmTI+IKqmGzZU13upQFGBBB15e9YiCX3idsDWSvkdM8SHuRIOzS/TRidlc9oPmzGjbB svsNTf/bnXdxzpTeGCQ1j/vKh+jN6pRZwtw+2YcGApciJYfjf3wOJ/0pwF3u1odBwL7I=; Original-Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9nIb-00039N-J3; Sat, 31 Jul 2021 13:37:04 +0200 In-Reply-To: <87mtq30y5w.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sat, 31 Jul 2021 09:56:11 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271891 Archived-At: Protesilaos Stavrou writes: > The idea is to have a command that moves point. So it could accept a > numeric argument to go to the COUNTth match, like 're-search-forward'. I grepped through the Emacs sources, and the COUNT parameter to `re-search-forward' was used in 2% of the usage cases, which is about 10000% more than I had imagined -- so perhaps it does make sense to add a COUNT parameter to `text-property-search-*' (especially for symmetry with `re-search-*'). But I'm for composability and trying to keeping function interfaces simple and easy to reason about -- there's a tendency to stuff more and more functionality down into functions when it's trivial to just use the functions instead. And these functions already have plenty of optional parameters (and will probably grow even more in the future, if Emacs history repeats itself), so I'm still not very excited about adding COUNT. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no