From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix memory-report--object-size for hashtable and vectors Date: Sat, 14 Aug 2021 13:46:44 +0200 Message-ID: <87o8a0uu3f.fsf@gnus.org> References: <67bebb91-aa22-4901-bf8a-d461c1a73454@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31014"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Yikai Zhao" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 14 13:48:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEs8u-0007pi-D5 for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Aug 2021 13:48:00 +0200 Original-Received: from localhost ([::1]:38472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEs8t-0005NP-2c for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Aug 2021 07:47:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEs7v-0004h6-51 for emacs-devel@gnu.org; Sat, 14 Aug 2021 07:46:59 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:50308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEs7t-0004Ni-Gw for emacs-devel@gnu.org; Sat, 14 Aug 2021 07:46:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=guDoGQsZFd70aHOokikq0BTvZbpULnl3sC/qw2EWZ5A=; b=C9HZnJ8UEGDrVDSEPqwbwBW+4i RQmie6sjPFXHECct1FnM9IFF1COHKHwC/hQpZ4IqKjrbabfavBXRuBfcKGqY/vvzTwAiKhdVbuv9z +5UROxVHcHsPPmjaeivICog+IBI3dE5TQF0pwsnXvm0JxjX2fk6eYlfKGbxzbftyDjNo=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEs7j-00006a-KU; Sat, 14 Aug 2021 13:46:51 +0200 In-Reply-To: <67bebb91-aa22-4901-bf8a-d461c1a73454@www.fastmail.com> (Yikai Zhao's message of "Sat, 14 Aug 2021 18:18:13 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272382 Archived-At: "Yikai Zhao" writes: > This is my first attempt to submit a patch to emacs, please let me > know if there's anything missing. Thanks! Thanks; looks good. I added some tests to test/lisp/emacs-lisp/memory-report-tests.el and pushed to Emacs 28. This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no